Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preview buttons in profile panel #64

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chanayane
Copy link
Contributor

Added preview buttons in profile panel to preview the About section, Picks and First Life introduction like others would see it, very useful to preview links with custom label for example.

I only have a little issue on the Picks panel, when it's dirty, and we toggle preview on and off, it won't restore the dirty state. If anyone knows why and how to fix that, I will gladly update the PR.

Here's what it looks like:

About section:
FirestormOS-AyaneStorm_A1dktgNTbG
FirestormOS-AyaneStorm_gwMjgR2g82

Picks:
FirestormOS-AyaneStorm_PES3Glx4fD
FirestormOS-AyaneStorm_pxi2CMHcgh

First Life:
FirestormOS-AyaneStorm_0VRSNp5EVJ
FirestormOS-AyaneStorm_CjCxSHdXXi

…Picks and First Life introduction like others would see it, useful to preview links for example
@beqjanus
Copy link
Contributor

Hiya @chanayane
You mentioned that this was draft cos you still had an issue with it (toggling picks not marked as dirty), what have you done in terms of debugging that so far?

@chanayane
Copy link
Contributor Author

Hiya @chanayane You mentioned that this was draft cos you still had an issue with it (toggling picks not marked as dirty), what have you done in terms of debugging that so far?

When clicking the preview button, I tried to save the "dirty" state of the pick so that when we press the preview button again to go back to edit mode, the "save" and "cancel" buttons would still be enabled. But I failed so far. Something does not work as I think it does. Any help on that would be very much appreciated!

@chanayane
Copy link
Contributor Author

It's like the dirty state of the texteditor gets reset and I cannot figure out why and how to put it back to dirty state programmatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants