Skip to content

Commit

Permalink
Fix for #24
Browse files Browse the repository at this point in the history
  • Loading branch information
@pcisar
pcisar committed Feb 9, 2024
1 parent 443da69 commit 0142fb1
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 5 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [0.19.1] - 2024-02-09

### FIXED

- Fix for #21. Dependency to pytest changed from `>=8.0.0` to `~=7.4`. Other dependecies
changed from `>=` to `~=`.

## [0.19.0] - 2024-02-08

### Changed
Expand Down
7 changes: 7 additions & 0 deletions docs/changelog.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ Changelog

.. currentmodule:: firebird.qa.plugin


Version 0.19.1
==============

* Fix for `#21 <https://github.com/FirebirdSQL/firebird-qa/issues/21>`_. Dependency to pytest
changed from `>=8.0.0` to `~=7.4`. Other dependecies changed from `>=` to `~=`.

Version 0.19.0
==============

Expand Down
8 changes: 4 additions & 4 deletions pyproject.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ classifiers = [
"Framework :: Pytest",
]
dependencies = [
"firebird-base>=1.7.1",
"firebird-driver>=1.10.1",
"pytest>=8.0.0",
"psutil>=5.9.8",
"firebird-base~=1.7.1",
"firebird-driver~=1.10.1",
"pytest~=7.4",
"psutil~=5.9.8",
]

[project.urls]
Expand Down
2 changes: 1 addition & 1 deletion src/firebird/qa/__about__.py
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: 2021-present The Firebird Projects <www.firebirdsql.org>
#
# SPDX-License-Identifier: MIT
__version__ = "0.19.0"
__version__ = "0.19.1"

2 comments on commit 0142fb1

@hvlad
Copy link
Member

@hvlad hvlad commented on 0142fb1 Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this commit I have errors running tests on WIndows

F:\FB2\firebird-qa>pytest --server local -vv tests\bugs\gh_7992_test.py
Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\Scripts\pytest.exe\__main__.py", line 7, in <module>
    sys.exit(console_main())
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\_pytest\config\__init__.py", line 190, in console_main
    code = main()
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\_pytest\config\__init__.py", line 148, in main
    config = _prepareconfig(args, plugins)
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\_pytest\config\__init__.py", line 329, in _prepareconfig
    config = pluginmanager.hook.pytest_cmdline_parse(
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\pluggy\_hooks.py", line 265, in __call__
    return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\pluggy\_manager.py", line 80, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\pluggy\_callers.py", line 55, in _multicall
    gen.send(outcome)
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\_pytest\helpconfig.py", line 103, in pytest_cmdline_parse
    config: Config = outcome.get_result()
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\pluggy\_result.py", line 60, in get_result
    raise ex[1].with_traceback(ex[2])
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\pluggy\_callers.py", line 39, in _multicall
    res = hook_impl.function(*args)
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\_pytest\config\__init__.py", line 1060, in pytest_cmdline_parse
    self.parse(args)
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\_pytest\config\__init__.py", line 1348, in parse
    self._preparse(args, addopts=addopts)
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\_pytest\config\__init__.py", line 1231, in _preparse
    self.pluginmanager.load_setuptools_entrypoints("pytest11")
  File "C:\Users\Vlad\AppData\Roaming\Python\Python310\site-packages\pluggy\_manager.py", line 287, in load_setuptools_entrypoints
    plugin = ep.load()
  File "C:\Program Files\Python310\lib\importlib\metadata\__init__.py", line 171, in load
    module = import_module(match.group('module'))
  File "C:\Program Files\Python310\lib\importlib\__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1004, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'firebird.qa'

It works again when reset to 1d314d5.

@hvlad
Copy link
Member

@hvlad hvlad commented on 0142fb1 Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip install -e . fixed the issue.
The needs to run it was far not obvious, while mentioned at https://firebird-qa.readthedocs.io/en/latest/usage-guide.html.
Also, since there is no more setup.cfg (removed previously), docs needs some update

Please sign in to comment.