-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds .NET distributed tracing instrumentation & metrics. #1200
base: master
Are you sure you want to change the base?
Conversation
Included the final portion of #1196 (metrics) here, as it requires the same infrastructure as traces. |
Here is before and after comparison of Perf benchmark results on my machine. BenchmarkDotNet=v0.13.2, OS=Windows 11 (10.0.26120.2130)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK=9.0.100-rc.2.24474.11
[Host] : .NET 8.0.10 (8.0.1024.46610), X64 RyuJIT AVX2
NuGet : .NET 6.0.35 (6.0.3524.45918), X64 RyuJIT AVX2
Project : .NET 6.0.35 (6.0.3524.45918), X64 RyuJIT AVX2
Jit=RyuJit Platform=X64 Toolchain=.NET 6.0
WarmupCount=3 Perf.CommandBenchmarkFirebirdSQL:master (Old) <-> fdcastel:add-telemetry-trace (New)
|
Thanks @willibrandon. This surely can be improved. Could you kindly share the steps/configuration you used for the above benchmark results? Mine here produces a comparison between |
@willibrandon I pushed a new PR in #1203 (it is based on this PR). Could you please clone it and run The script will compare the current project (built from sources with .NET8) with the latest NuGet release (
|
@fdcastel - Interesting, and thanks! Taking a look now. |
Okay, I see how the performance project works now with the conditional project/package reference, and with the latest Nuget release being the baseline. That is way better approach than the way I was attempting to compare the the results historically. @fdcastel - Thank you very much for showing me how the performance project works. I just want try and confirm we haven't regressed in someway with this change. |
Initial work for #1196.