Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable expand_as_any serialize & deserialize a pair of type_url and value #20

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Enable expand_as_any serialize & deserialize a pair of type_url and value #20

merged 7 commits into from
Mar 5, 2024

Conversation

170210
Copy link

@170210 170210 commented Feb 29, 2024

close #19

@170210 170210 requested a review from loloicci February 29, 2024 10:50
@170210 170210 self-assigned this Feb 29, 2024
@170210 170210 marked this pull request as ready for review March 1, 2024 11:02
@170210 170210 marked this pull request as draft March 4, 2024 02:04
@170210 170210 marked this pull request as ready for review March 4, 2024 02:54
@170210 170210 requested review from zemyblue and Kynea0b March 4, 2024 03:37
loloicci
loloicci reviewed Mar 4, 2024
View reviewed changes
Copy link

@loloicci loloicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto to other tests.

packages/finschia-std/src/shim.rs Outdated Show resolved Hide resolved
packages/finschia-std/src/shim.rs Outdated Show resolved Hide resolved
@170210
fix: fix for comment
c3bcf9d 
Signed-off-by: 170210 <[email protected]>
@170210 170210 requested a review from ulbqb March 4, 2024 09:23
@ulbqb
Copy link
Member

ulbqb commented Mar 4, 2024 •
edited
Loading

It's would be good to return earily before the at_type case if data has type_url.

@170210
Copy link
Author

170210 commented Mar 5, 2024

@ulbqb No, we cannot. If there is a grpc has type_url and value field in the future, it will make wrong. And @type is outside of submessage, so we need first consider the @type.

@170210 170210 merged commit 34657ff into main Mar 5, 2024
3 checks passed
@170210 170210 deleted the feat/anyType branch March 5, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulbqb ulbqb ulbqb approved these changes

@loloicci loloicci loloicci approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

@Kynea0b Kynea0b Awaiting requested review from Kynea0b

Assignees

@170210 170210

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable expand_as_any deserialize a pair of type_url and value
3 participants
@170210 @ulbqb @loloicci