Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable sonar analysis #1241

Open
wants to merge 1 commit into
base: bumpup50
Choose a base branch
from
Open

ci: enable sonar analysis #1241

wants to merge 1 commit into from

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Feb 15, 2024

Description

This patch would enable sonar analysis and update its config.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Feb 15, 2024
@github-actions github-actions bot added the C:x/foundation x/foundation module label Feb 15, 2024
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions github-actions bot added the A: CI label Feb 15, 2024
@0Tech 0Tech marked this pull request as ready for review February 16, 2024 05:29
@0Tech 0Tech requested a review from a team as a code owner February 16, 2024 05:29
@ulbqb
Copy link
Member

ulbqb commented Feb 20, 2024

How about apply this for stakingplus and bankplus, too?

sonar.project.monorepo.enabled=true

sonar.sources=.
sonar.exclusions=**/*_test.go
Copy link
Contributor

@jaeseung-bae jaeseung-bae Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonar.exclusions=**/*_test.go
Can we move common exclusions to above(root sonar-project.properties)?
And how about adding pb files **/*.pb.go to common as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: CI C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants