This repository has been archived by the owner on Aug 10, 2022. It is now read-only.
Make config file support both Rack and Rails #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'll merge this in once I have time to port the pane to MacRuby. Thanks! |
|
Just checking in on this.. Any progress? |
|
There has been much progress, but it’s all on the experimental branch: https://github.com/Fingertips/passengerpane/tree/experimental Not finished yet, though, so please bear with us. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, I don't think i have a proper Ruby Cocoa setup so it was hard for me to test this. The current master code doesn't work for me before I even made this change. But I think you can get the gist of it. Seems like a better way of dealing with either case.
Cheers.