The convenience method should use fitSize instead of targetSize.

Fingertips · Oct 11, 2012 · 5d4338c · 5d4338c
1 parent 3c15e72
commit 5d4338c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/Source/FTPDFIconRenderer.h b/Source/FTPDFIconRenderer.h
@@ -24,9 +24,9 @@
                                    targetColor:(UIColor *)targetColor;
 
 + (UIImage *)imageOfPDFNamed:(NSString *)pdfName
-                  targetSize:(CGSize)targetSize;
+                     fitSize:(CGSize)maxSize;
 + (UIImage *)imageOfPDFNamed:(NSString *)pdfName
-                  targetSize:(CGSize)targetSize
+                     fitSize:(CGSize)maxSize
                  targetColor:(UIColor *)targetColor
               withIdentifier:(NSString *)identifier;
 
@@ -44,7 +44,7 @@
                  targetColor:(UIColor *)targetColor
               withIdentifier:(NSString *)identifier;
 
-- (void)fitSize:(CGSize)size;
+- (void)fitSize:(CGSize)maxSize;
 - (void)fitWidth:(CGFloat)targetWidth;
 - (void)fitHeight:(CGFloat)targetHeight;
 

diff --git a/Source/FTPDFIconRenderer.m b/Source/FTPDFIconRenderer.m
@@ -53,14 +53,14 @@ + (FTPDFIconRenderer *)iconRendererForPDFNamed:(NSString *)pdfName
 }
 
 + (UIImage *)imageOfPDFNamed:(NSString *)pdfName
-                  targetSize:(CGSize)targetSize
+                     fitSize:(CGSize)maxSize
                  targetColor:(UIColor *)targetColor
               withIdentifier:(NSString *)identifier;
 {
   FTPDFIconRenderer *renderer = [self iconRendererForPDFNamed:pdfName
                                                   targetColor:targetColor];
   if (renderer) {
-    renderer.targetSize = targetSize;
+    [renderer fitSize:maxSize];
     return [renderer imageWithCacheIdentifier:identifier];
   }
   return nil;
@@ -102,10 +102,10 @@ + (FTPDFIconRenderer *)iconRendererForPDFNamed:(NSString *)pdfName;
 }
 
 + (UIImage *)imageOfPDFNamed:(NSString *)pdfName
-                  targetSize:(CGSize)targetSize;
+                     fitSize:(CGSize)maxSize
 {
   return [self imageOfPDFNamed:pdfName
-                    targetSize:targetSize
+                       fitSize:maxSize
                    targetColor:nil
                 withIdentifier:nil];
 }
@@ -187,10 +187,10 @@ - (CGSize)targetSize;
   return _targetSize;
 }
 
-- (void)fitSize:(CGSize)size;
+- (void)fitSize:(CGSize)maxSize;
 {
   CGRect mediaRect = self.mediaRectOfSourcePage;
-  CGFloat scaleFactor = MAX(mediaRect.size.width / size.width, mediaRect.size.height / size.height);
+  CGFloat scaleFactor = MAX(mediaRect.size.width / maxSize.width, mediaRect.size.height / maxSize.height);
   self.targetSize = CGSizeMake(ceilf(mediaRect.size.width / scaleFactor), ceilf(mediaRect.size.height / scaleFactor));
 }