Skip to content
This repository has been archived by the owner on May 22, 2019. It is now read-only.

[WIP] add whitesource to Makefile #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andygnewman
Copy link
Contributor

@andygnewman andygnewman commented Aug 11, 2016

Need to check a couple of things about how whitesource writes reports (overwrites npm report with bower report) before spreading this out more widely.

Have created a PR for the required changes to Whitesource

@andygnewman andygnewman changed the title add whitesource to Makefile [WIP] add whitesource to Makefile Aug 11, 2016
@matthew-andrews
Copy link
Contributor

+1

@andygnewman
Copy link
Contributor Author

Unfortunately Whitesource rejected the PR and their proposed solution is to have a separate config file for each package manager (bower & npm).

So changes here are;

  • create two whitesource config json files (npm & bower)
  • move check for package.json / bower.json into the config creation rather than executing whitesource
  • add custom file path to each execution

@andygnewman
Copy link
Contributor Author

@matthew-andrews
Copy link
Contributor

still +1 from me

@andygnewman
Copy link
Contributor Author

Haven't had the opportunity to test it locally yet - will do that before merging.

@andygnewman
Copy link
Contributor Author

OK, have tested locally, however when Whitesource released the latest versions (which allowed for the different reports for bower / npm packages), I discovered (after much head scratching) that they'd saved it with Windows/DOS line endings rather than Unix, so the command line wasn't operating.

Have raised it with them.

But did change it locally and tested and all works as expected.

Plus have put together a little Wiki page in n-Makefile describing how to enable Whitesource for an app https://github.com/Financial-Times/n-makefile/wiki/Whitesource.

Will hold off merging in till we get working Whitesource modules.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants