Uppercase all HTTP verbs for native Fetch support

Standard Fetch spec will only automatically uppercase rfc9110-compliant http verbs. This commit sets a convention of uppercase http verbs in this project - whether standard or custom.
Financial-Times · Mar 21, 2023 · 9a790d3 · 9a790d3
1 parent 85f53ba
commit 9a790d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/heroku-config-vars.js b/lib/heroku-config-vars.js
@@ -49,7 +49,7 @@ class HerokuConfigVars {
 	*/
 	set (patch) {
 		return this.makeApiCall({
-			method: 'patch',
+			method: 'PATCH',
 			body: JSON.stringify(patch)
 		});
 	}

diff --git a/lib/review-apps.js b/lib/review-apps.js
@@ -125,7 +125,7 @@ const deleteReviewAppAndThrowError = async ({ reviewApp, commit, appId }) => {
 
 		const headers = await herokuHeaders({ useReviewAppApi: true });
 
-		await performFetch(getReviewAppUrl(reviewApp.id), { headers, method: 'delete' });
+		await performFetch(getReviewAppUrl(reviewApp.id), { headers, method: 'DELETE' });
 
 	} catch (error) {
 
@@ -261,7 +261,7 @@ const createReviewApp = async ({ pipelineId, repoName, commit, branch, githubTok
 		}
 	};
 
-	const response = await fetch(REVIEW_APPS_URL, { headers, method: 'post', body: JSON.stringify(body) });
+	const response = await fetch(REVIEW_APPS_URL, { headers, method: 'POST', body: JSON.stringify(body) });
 
 	return response;