Merge pull request #126 from Financial-Times/fail-build-when-build-fails

Fail the build when the build fails

tasks/build.js

@@ -32,7 +32,8 @@ function run(task, opts) {
 			console.log("Watching " + getGlob(task) + " and will trigger " + task);
 			gulp.watch(getGlob(task), [task]);
 		} else {
-			gulp.start([task], resolve);
+			gulp.start([task], resolve)
+				.on('error', reject);
 		}
 	});
 }
@@ -43,11 +44,12 @@ gulp.task('build-sass', function() {
 			buildFolder: buildFolder,
 			env: isDev ? 'development' : 'production'
 		})
-		.on('end', function () {
+		.on('end', function() {
 			console.log('build-sass completed');
 		})
-		.on('error', function () {
+		.on('error', function(err) {
 			console.warn('build-sass errored');
+			throw err;
 		});
 });
 
@@ -57,11 +59,12 @@ gulp.task('build-js', function() {
 			buildFolder: buildFolder,
 			env: 'development' // need to run as development as we do our own sourcemaps
 		})
-		.on('end', function () {
+		.on('end', function() {
 			console.log('build-js completed');
 		})
-		.on('error', function () {
+		.on('error', function(err) {
 			console.warn('build-js errored');
+			throw err;
 		});
 });
 
@@ -71,11 +74,12 @@ gulp.task('build-minify-js', ['build-js'], function() {
 		.pipe(extractSourceMap({ saveTo: buildFolder + mainJsSourceMapFile }))
 		.pipe(minify({ sourceMapIn: buildFolder + mainJsSourceMapFile, sourceMapOut: '/' + app + '/' + mainJsSourceMapFile }))
 		.pipe(gulp.dest(buildFolder))
-		.on('end', function () {
+		.on('end', function() {
 			console.log('build-minify-js completed');
 		})
-		.on('error', function () {
+		.on('error', function(err) {
 			console.log('build-minify-js errored');
+			throw err;
 		});
 });