Merge pull request #136 from Financial-Times/set-article-body

Set property directly, rather than using defineProperty

.travis.yml

@@ -5,7 +5,7 @@ script:
 - make test
 node_js:
 - '0.10'
-- '0.12'
+- '0.12.2'
 before_deploy:
 - npm-prepublish --verbose
 deploy:

lib/models/article.js

@@ -24,7 +24,16 @@ Article.prototype.parse = function (obj) {
 	this.id = obj.item.id;
 	this.raw = obj;
 
-	if (!this.raw.item.body) return;
+	if (this.raw.item.body) {
+		var html = this.raw.item.body.body;
+		try {
+			this.body = dom.removeNonArticleLinks(dom.fixRelativeLinks(dom.removeEmptyParagraphs(html)));
+		} catch (e) {
+			this.body = '<p>Error parsing this article.</p>';
+		}
+	} else {
+		this.body = '';
+	}
 };
 
 /**
@@ -38,6 +47,9 @@ Article.prototype.paragraphs = function (to, from, options) {
 	return $('p').slice(to, from);
 };
 
+// TODO: move the following out of defineProperty and just set `this` directly
+// https://github.com/Financial-Times/ft-api-client/pull/136
+
 /**
  * Returns a list of inbound links to other FT articles contained within the article body
  */
@@ -469,25 +481,6 @@ Object.defineProperty(Article.prototype, 'quotes', {
 	}
 });
 
-/**
- * The article body as HTML.
- */
-Object.defineProperty(Article.prototype, 'body', {
-	get: function () {
-
-		var html = this.raw.item.body.body;
-
-		try {
-			return dom.removeNonArticleLinks(dom.fixRelativeLinks(dom.removeEmptyParagraphs(html)));
-		} catch (e) {
-			// console.error('Error parsing article body', e);
-			return '<p>Error parsing this article.</p>';
-		}
-
-
-	}
-});
-
 /**
  * The largest image (ie. in pixels) that is associated with the resource
  */