Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tray tooltip more consistently #1426

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Update tray tooltip more consistently #1426

merged 2 commits into from
Aug 9, 2023

Conversation

Tester798
Copy link
Contributor

@Tester798 Tester798 commented Aug 7, 2023 •
edited
Loading

There is some inconsistency while updating tray tooltip currently. This pull request should fix it.

test.mp4

@Tester798 Tester798 mentioned this pull request Aug 7, 2023
Closed
riverar
riverar requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@riverar riverar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a nit--in this codebase, we don't lowercase private methods. Ready to merge otherwise.

EarTrumpet/App.xaml.cs Outdated Show resolved Hide resolved
EarTrumpet/App.xaml.cs Outdated Show resolved Hide resolved
@riverar riverar merged commit 5b0c7f0 into File-New-Project:dev Aug 9, 2023
4 checks passed
@Tester798 Tester798 deleted the fix-tray-tooltip branch August 9, 2023 19:32
@Tester798 Tester798 mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riverar riverar riverar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tester798 @riverar