Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp futures #209

Open
wants to merge 9 commits into
base: 1.20
Choose a base branch
from
Open

Revamp futures #209

wants to merge 9 commits into from

Conversation

PoolloverNathan
Copy link
Contributor

No description provided.

@PoolloverNathan PoolloverNathan marked this pull request as ready for review April 4, 2024 15:51
@PoolloverNathan PoolloverNathan marked this pull request as draft April 4, 2024 15:52
@PoolloverNathan
Copy link
Contributor Author

I thought I lost the code for this and completely forgot that it's a PR

@PoolloverNathan PoolloverNathan marked this pull request as ready for review November 17, 2024 18:18
@PoolloverNathan
Copy link
Contributor Author

should be threadsafe now — I'll do some testing later

@PoolloverNathan
Copy link
Contributor Author

@UnlikePaladin can I request a review?

UnlikePaladin
UnlikePaladin approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@UnlikePaladin UnlikePaladin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@UnlikePaladin
Copy link
Member

but it will have to wait for 0.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnlikePaladin UnlikePaladin UnlikePaladin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PoolloverNathan @UnlikePaladin