Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Q7 for GHAS #128

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Update Q7 for GHAS #128

merged 3 commits into from
Jan 8, 2024

Conversation

garysassano
Copy link
Contributor

PR Type

  • Content changes (add/update questions, answers, explanations)
  • Bugfix
  • Feature
  • Refactor (no functional changes)
  • Documentation changes
  • Other

What's new?

Current question has two possible correct answers and not too much clear.

Related issue(s)

Screenshots

@github-actions github-actions bot added advanced security Related to GitHub Advanced Security Exam content Related to the content of the site labels Jan 6, 2024
Copy link
Owner

@FidelusAleksander FidelusAleksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @garysassano

  1. I'm not sure which other answer You think is correct aswell in the current question? I personally think the current state is correct, but curious to hear Your view.
  2. This is a whole question rewrite, instead add a new question with what You just wrote please.

@garysassano
Copy link
Contributor Author

@FidelusAleksander Let's make the answer options less ambiguous.

Copy link
Owner

@FidelusAleksander FidelusAleksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small but important change, then it's ready to merge

content/questions/advanced_security/question-007.md Outdated Show resolved Hide resolved
@FidelusAleksander
Copy link
Owner

@garysassano

de9770f

This commit was good, but You changed it again into a multiple choice question syntax :)

@garysassano
Copy link
Contributor Author

@FidelusAleksander My bad, didn't realize that's how the current system works: I thought the two syntaxes were interchangeable.

@FidelusAleksander FidelusAleksander merged commit bb396f0 into FidelusAleksander:master Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced security Related to GitHub Advanced Security Exam content Related to the content of the site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants