Replace openssl hash functions with RustCrypto hashes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See RustCrypto/traits#1683 for more details on errors
dishmaker
reviewed
Oct 26, 2024
| } else if Oid::const_new(&[2, 16, 840, 1, 101, 3, 4, 2, 2]).eq(oid) { | ||
| Ok(Box::new(sha2::Sha384::default())) | ||
| } else if Oid::const_new(&[2, 16, 840, 1, 101, 3, 4, 2, 1]).eq(oid) { | ||
| Ok(Box::new(sha2::Sha256::default())) |
There was a problem hiding this comment.
There might be a better way. But probably slower
https://github.com/RustCrypto/formats/blob/0bd9dea37e3d8cccdb5f7ba5a402f62553d07e05/cms/src/builder.rs#L1061-L1077
There was a problem hiding this comment.
Hey, thanks for the comment. It seems that with that approach, I would need to use an oid database (der::oid::db::DB). Since oids do not change, I think it's better to have them hardcoded. Even though it looks cleaner, I would rather have very little dependency footprint. Currently, I have quite many dependencies but I plan to reduce them in time.
RustCrypto is missing brainpool curves, so the signature verification is not implemented still RSA and DSA are also not implemented
|
RustCrypto is missing Brainpool and some other elliptic curve algorithms (RustCrypto/elliptic-curves#114) |
Fethbita
commented
Oct 27, 2024
| // <https://www.icao.int/publications/Documents/9303_p12_cons_en.pdf> | ||
| // > MUST be v3 | ||
| if cert.tbs_certificate.version.ne(&rasn_pkix::Version::V3) { | ||
| error!("DSC TBSCertificate version must be v3"); |
| )); | ||
| let signature_algorithm = &signer_info.signature_algorithm; | ||
| let signature = der::encode(&signer_info.signature).map_err(EmrtdError::RasnEncodeError)?; | ||
| // let pub_key = dsc.public_key().map_err(EmrtdError::OpensslErrorStack)?; |
| return Err(EmrtdError::VerifySignatureError( | ||
| "Signature verification failure during Master List parsing", | ||
| )); | ||
| // let pub_key = master_list_signer |
| // let chain = Stack::new().map_err(EmrtdError::OpensslErrorStack)?; | ||
| // let mut store_bldr = | ||
| // X509StoreBuilder::new().map_err(EmrtdError::OpensslErrorStack)?; | ||
| // store_bldr |
| // <https://www.icao.int/publications/Documents/9303_p12_cons_en.pdf> | ||
| // > Dates through 2049 MUST be in UTCTime UTCTime MUST be represented as YYMMDDHHMMSSZ | ||
| rasn_pkix::Time::Utc(date_time) => { | ||
| // todo!() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim is to remove openssl dependency eventually. See RustCrypto/traits#1683 for more details on where I am stuck right now.