forked from Elisseeff-Lab/domino
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.2.2 development #51
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definition of the linkage summary class added to facilitate comparisons of linkages established in domino objects across sample covariates.
updating readme with archived versions of domino from publication.
also includes a bug fix where lists of linkage counts were being saved into the resulting data frame instead of a numeric vector.
Changed base from master to alt_gene_conversions_&_class_checks to integrate with compare_linkages changes intended for v0.2.2
Changed base from master to alt_gene_conversions_&_class_checks to integrate with compare_linkages changes intended for v0.2.2
Changed base from master to alt_gene_conversions_&_class_checks to integrate with compare_linkages changes intended for v0.2.2
Removed deleted function get_regulon_info
Adjusted documentation of the domino class to reflect current usage. This branch is being merged back to development despite not correcting the NAMESPACE error because I have yet to find a solution. I want to give time to hear back from BiocCheck's developers while addressing other tasks at hand.
35 error. Error message in BiocCheck is not resolved, but dev_tools::check finds no issues with NAMESPACE
Initial addition of BiocViews. Uses Views "SystemsBiology, SingleCell, Transcriptomics, Network". BiocCheck recommends including "Transcription, Sequencing, DataImport"
Tabs had been used in a code block for the bash script used to run pySCENIC.
Most functions in the plotting_fxns script did not have \@return fields filled out. Also added these descriptions for the print functions for the domino S4 class.
…ting_functions value added for docs on plotting functions
…ino2 into krishnan_pkgdown
Replaces instances of using NMF::aheatmap to render heatmaps with ComplexHeatmap functions. Existing purposes of the plots and capabilities to pass arguments to the domino plotting function to the Heatmap() function are maintained.
R CMD CHECK failed when rebuilding vignettes because of issues parsing lines in function arguments that included comments. the comments have been moved to separate lines.
Rerun construction of pkgdown files to account for changes to plotting functions used in the vignettes.
Function definition appeared a second time. Likely arose from merging branches earlier.
Update pkgdown files, reorganize data files
aheatmap is no longer used in the package, so NMF no longer needs to be imported
Resolve devtools::check() for usage of Seurat, loomR, and patchwork in the vignette markdown scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.