108 create rl map cellphonedb input checks and readins #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmitchell81
approved these changes
Mar 13, 2024
drbergman
reviewed
Mar 13, 2024
| if (alternate_convert & is.null(alternate_convert_table)) { | ||
| stop("If using alternate conversion table (not recommended), a table must be provided") | ||
| } | ||
| check_arg(genes, c("character", "data.frame")) |
There was a problem hiding this comment.
it looks like the read_if_char function acts on genes below in a way that requires genes to be a single character. So, should this also include a check as below of allow_len = c(1)?
Similarly for next few lines.
There was a problem hiding this comment.
valid point, addressed in bd01e01
drbergman
reviewed
Mar 13, 2024
| } | ||
| } | ||
| } | ||
| genes <- conv_py_bools(genes) |
There was a problem hiding this comment.
Any concern that any of these might contain all True's or all False's? It looks like conv_py_bools will only make changes if both are present.
There was a problem hiding this comment.
@jmitchell81 could there be cases with only True or only False that we need to care about?
drbergman
reviewed
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored: