forked from Elisseeff-Lab/domino
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #84 from FertigLab/dimalvovs-patch-1
Create pull_request_template.md
- Loading branch information
Showing
1 changed file
with
17 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
This is a code review template, it will be displayed after each pull request. | ||
We do code reviews because we care about quality of our codebase and because we care about long-term development goals. | ||
We do not do code reviews to blame the ones who contribute. There is no seniority in this process and there is no perfect code, | ||
we just want to avoid storing code that is not OK. | ||
|
||
## For the submitter | ||
|
||
- [ ] `R CMD build` & `R CMD check` pass | ||
- [ ] Needed tests exist and passing or not needed | ||
- [ ] The change is sufficiently small | ||
|
||
## For the reviewer | ||
|
||
- [ ] OK, code does what it's intended for | ||
- [ ] its' OK to do it that way | ||
- [ ] it's OK to read and comprehend the code | ||
- [ ] tests, documentation, style are OK |