fix: CLIN-3610 use container tag 1.20 instead latest for split multia… #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using the "latest" tag for the bcftools container in the SplitMultiAllelics process.
To make the pipeline more stable and reproducible, we will use a specific tag instead (1.20). We used the same version as other processes based on bcftools.
Tests
Run the pipeline locally on this branch and on the main branch:
nextflow run main.nf -profile test,docker
Compare the output for the splitMultiAllelics process. The bodies of the vcf files should be identical.
On the current branch, open the nextflow execution report (pipeline info output folder) and double check that the container is bcftools:1.20
Juno tests
Run the pipeline in juno. Make sure that the container used if bcftools:1.20 and not bcftools:latest.
Linter Warnings
For the linter, we still see the warning
Container versions do not match
for the split_multi_allelics module, which is also present on the main branch. We thought simply removing the container definition in the module would fix it, but it doesn't. We will not address this problem in the present PR. We shall revisit this later when standardizing the module.PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.docs/reference_data.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).