Dec 21 '23 last changes before audit. #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setDecentralizedStatesStatus fn emits the event before the fn routine finishes. The reason is to show old state from storage and the new state from call data. Comments are added to setDecentralizedStatesStatus in FlashMintModule and StableSwapModule.
0)events for setAccessControlConfig fns were missing before. Therefore, added in this commit. 1)prettier 2)solhint
0)LogSetBookKeeper event added 1)LogAddToWhitelist, LogRemoveFromWhitelist events added 2)LogNewDebtAccumulatedRate event added
TonioMacaronio
requested changes
Dec 21, 2023
contracts/main/stablecoin-core/liquidation-strategies/FixedSpreadLiquidationStrategy.sol
Outdated
Show resolved
Hide resolved
0)no need to index core smart contract addresses that are switched as the number will not be a lot and no need to search for. 1)adding indexed keywords to LogProxyWalletCreation event since owner and proxy wallet information is important.
TonioMacaronio
approved these changes
Dec 21, 2023
codinghistorian
pushed a commit
that referenced
this pull request
Jan 31, 2024
Dec 21 '23 last changes before audit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A list of commits.
FXD-72 '23 Dec 21 clean indexed event param changes
FXD-72 '23 Dec 21 clean comments on test script
FXD-72 '23 Dec 21 remove deprecated storage slots
FXD-72 '23 Dec 21 adding event to WL, setBookKeeper fns
FXD-72 '23 Dec 21 adding event to setAccessControlConfig fns
FXD-72 '23 Dec 21 adding comment to setDecentralizedStatesStatus fn