Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change project src folder layout to use subfolder 'ale' #533

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

maichmueller
Copy link
Contributor

Fixes #532

@pseudo-rnd-thoughts
Copy link
Member

@maichmueller I think the issue is related to NumPy 2.0, if you limit the numpy<2.0 in pyproject.toml this will probably fix

@maichmueller
Copy link
Contributor Author

Hi @pseudo-rnd-thoughts ,

Thanks for the hint! But this small numpy change now seems to cause the… vcpkg step to fail? I don’t quite understand the CI setup in how the steps interoperate; the changes in commits often don’t appear to me to correlate with the errors in the CI steps.

@pseudo-rnd-thoughts
Copy link
Member

@maichmueller There were several issues with the CI that took a while to fix.
Could you merge with main and see if vcpkg is fix

@maichmueller
Copy link
Contributor Author

maichmueller commented Jul 24, 2024

@pseudo-rnd-thoughts ,

thanks for those fixes! It seems the underlying CI issues have been resolved and all tests run successfully now. I am happy to bring this draft to full PR status then if you agree.

@pseudo-rnd-thoughts
Copy link
Member

@maichmueller Thanks for sorting this, I'm not confident enough to confirm implementation
@JesseFarebro Could you look at this? I believe you should have the c++ expertise, if not please say

@maichmueller maichmueller marked this pull request as ready for review September 1, 2024 12:47
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand now, looks good to me

Thanks again for the PR @maichmueller

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 4069a48 into Farama-Foundation:master Sep 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect cmake configuration / include layout post installation
2 participants