-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change project src folder layout to use subfolder 'ale' #533
Change project src folder layout to use subfolder 'ale' #533
Conversation
@maichmueller I think the issue is related to NumPy 2.0, if you limit the |
Hi @pseudo-rnd-thoughts , Thanks for the hint! But this small numpy change now seems to cause the… vcpkg step to fail? I don’t quite understand the CI setup in how the steps interoperate; the changes in commits often don’t appear to me to correlate with the errors in the CI steps. |
@maichmueller There were several issues with the CI that took a while to fix. |
thanks for those fixes! It seems the underlying CI issues have been resolved and all tests run successfully now. I am happy to bring this draft to full PR status then if you agree. |
@maichmueller Thanks for sorting this, I'm not confident enough to confirm implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand now, looks good to me
Thanks again for the PR @maichmueller
4069a48
into
Farama-Foundation:master
Fixes #532