add script for explicit download roms

.github/workflows/ci.yml

@@ -107,6 +107,9 @@ jobs:
     - name: Build
       run: python -m pip install --user --verbose .[test]
 
+    - name: Download and extract roms
+      run: ale-accept-license-install-roms
+
     - name: Test
       run: python -m pytest
 

pyproject.toml

@@ -52,13 +52,12 @@ documentation = "https://github.com/mgbellemare/Arcade-Learning-Environment/tree
 changelog = "https://github.com/mgbellemare/Arcade-Learning-Environment/blob/master/CHANGELOG.md"
 
 [project.scripts]
-ale-import-roms = "ale_py.scripts.import_roms:main"
+ale-accept-license-install-roms = "ale_py.roms:_download_roms"
 
 [tool.setuptools]
 packages = [
   "ale_py",
   "ale_py.roms",
-  "ale_py.scripts"
 ]
 package-dir = {ale_py = "src/python"}
 package-data = {"ale_py" = ["py.typed", "*.pyi", "**/*.pyi"], "ale_py.roms" = ["md5.json"]}

src/python/roms/__init__.py

@@ -59,6 +59,8 @@ def _download_roms():
         rom_path = Path(__file__).parent / rom_name
         open(rom_path, "wb").write(rom_bytes)
 
+        print(f"Downloaded and extracted {rom_name}.")
+
 
 def get_rom_path(name: str) -> Path | None:
     """Expects name as a snake_case name, returns the full path of the .bin file if it's valid, otherwise returns None."""
@@ -76,10 +78,13 @@ def get_rom_path(name: str) -> Path | None:
         # if the path exists, just return it
         return bin_path
     else:
-        # if it doesn't exist, we need to install the roms, then return it
-        print(f"Could not find rom {name}, downloading roms to device...")
-        _download_roms()
-        return bin_path
+        # if it doesn't exist, prompt the user to download it, just quit here.
+        print(
+            f"Looks like the rom {name} could not be found. "
+            "To install all roms, please run `ale-accept-license-install-roms` "
+            "to accept the license agreement and install all available roms."
+        )
+        exit()
 
 
 def get_all_rom_ids() -> list[str]: