Pure Continuous version of ALE on CPP (#550)

Co-authored-by: Jet <[email protected]>

pyproject.toml

@@ -20,7 +20,7 @@ authors = [
   {name = "Michael Bowling"},
 ]
 maintainers = [
-  { name = "Farama Foundation", email = "[email protected]" },
+  {name = "Farama Foundation", email = "[email protected]"},
   {name = "Jesse Farebrother", email = "[email protected]"},
 ]
 classifiers = [

src/ale_interface.cpp

@@ -259,16 +259,9 @@ int ALEInterface::lives() {
 // user's responsibility to check if the game has ended and reset
 // when necessary - this method will keep pressing buttons on the
 // game over screen.
-reward_t ALEInterface::act(Action action) {
-  return environment->act(action, PLAYER_B_NOOP);
-}
-
-// Applies a continuous action to the game and returns the reward. It is the
-// user's responsibility to check if the game has ended and reset
-// when necessary - this method will keep pressing buttons on the
-// game over screen.
-reward_t ALEInterface::actContinuous(float r, float theta, float fire) {
-  return environment->actContinuous(r, theta, fire, 0.0, 0.0, 0.0);
+// Intentionally set player B actions to 0 since we are in single player mode
+reward_t ALEInterface::act(Action action, float paddle_strength) {
+  return environment->act(action, PLAYER_B_NOOP, paddle_strength, 0.0);
 }
 
 // Returns the vector of modes available for the current game.

src/ale_interface.hpp

@@ -86,13 +86,7 @@ class ALEInterface {
   // user's responsibility to check if the game has ended and reset
   // when necessary - this method will keep pressing buttons on the
   // game over screen.
-  reward_t act(Action action);
-
-  // Applies a continuous action to the game and returns the reward. It is the
-  // user's responsibility to check if the game has ended and reset
-  // when necessary - this method will keep pressing buttons on the
-  // game over screen.
-  reward_t actContinuous(float r, float theta, float fire);
+  reward_t act(Action action, float paddle_strength = 1.0);
 
   // Indicates if the game has ended.
   bool game_over(bool with_truncation = true) const;

src/emucore/Settings.cxx

@@ -415,7 +415,6 @@ void Settings::setDefaultSettings() {
     boolSettings.insert(std::pair<std::string, bool>("send_rgb", false));
     intSettings.insert(std::pair<std::string, int>("frame_skip", 1));
     floatSettings.insert(std::pair<std::string, float>("repeat_action_probability", 0.25));
-    floatSettings.insert(std::pair<std::string, float>("continuous_action_threshold", 0.5));
     stringSettings.insert(std::pair<std::string, std::string>("rom_file", ""));
     // Whether to truncate an episode on loss of life.
     boolSettings.insert(std::pair<std::string, bool>("truncate_on_loss_of_life", false));