Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where searching for old tests that were yml failed to find #184

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

tkmcmaster
Copy link
Collaborator

@tkmcmaster tkmcmaster commented Dec 12, 2023

…find

- Changed the s3 listFiles by extension and PPaasS3File getAllFilesInS3 to allow an extension array
- Changed the TestManager searchTests to search for both .yaml and .yml files when searching for old tests
@tkmcmaster tkmcmaster requested review from burnsidepj and a team December 12, 2023 21:48
@tkmcmaster tkmcmaster self-assigned this Dec 12, 2023
@tkmcmaster
Copy link
Collaborator Author

@burnsidepj This should fix the issue you had where you couldn't find the old tests. They were .yml files rather than .yaml files. This will be fixed the next time we deploy the controller.

@tkmcmaster tkmcmaster marked this pull request as draft December 12, 2023 22:15
@tkmcmaster tkmcmaster marked this pull request as ready for review December 12, 2023 22:35
@tkmcmaster tkmcmaster merged commit a294528 into master Dec 13, 2023
2 checks passed
@tkmcmaster tkmcmaster deleted the fixSearchYmlFiles branch December 13, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants