Scripting fixes20231027 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tkmcmaster
commented
Oct 27, 2023
•
tkmcmaster
commented
- Fixed the issue where vars cannot be floats
- Fixed issue with trailing slash on Map Vars
- Added fixes for declare returning stringified json
- Added fix for collect always returning stringified json if it is returning an array of objects
- Added fix for declare expressions that were escaping json in the declare
- Added example yaml that shows json in vars, declare, and collect objects
- Added vars parsing of floating point to the integration test
- Fixed global loggers
- In configV1 they were added in from_config to all endpoints during the config parsing. In from_yaml we were not doing that similarly. We now add all loggers (with a query/select) to all endpoints like in the old code
- Updated the README to remove the bugs that were fixed
- Cleaned up todo code to return error
- Added fix for collect always returning stringified json if it is returning an array of objects - Added fix for declare expressions that were escaping json in the declare - Added example yaml that shows json in vars, declare, and collect objects
- In configV1 they were added in from_config to all endpoints during the config parsing. In from_yaml we were not doing that similarly. We now add all loggers (with a query/select) to all endpoints like in the old code
summersjc
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.