Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated ISO currency codes #920

Merged
merged 1 commit into from
Dec 8, 2024
Merged

fix: Updated ISO currency codes #920

merged 1 commit into from
Dec 8, 2024

Conversation

vjandrea
Copy link

@vjandrea vjandrea commented Dec 6, 2024

What is the reason for this PR?

Author's checklist

Summary of changes

Updated the currencies list to reflect the current ISO-4217 norm

Review checklist

  • All checks have passed
  • Changes are added to the CHANGELOG.md
  • Changes are approved by maintainer

@pimjansen
Copy link

pimjansen commented Dec 7, 2024

This should go to 1.x instead. Can you rebase this from the 1.24 branch instead?

@pimjansen pimjansen changed the base branch from 2.0 to 1.24 December 7, 2024 12:28
@vjandrea
Copy link
Author

vjandrea commented Dec 7, 2024

Sure!

@pimjansen pimjansen merged commit bbc79fe into FakerPHP:1.24 Dec 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants