Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ConvulseAmount" affliction effect parameter #14583

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TheNinjaScout
Copy link

@TheNinjaScout TheNinjaScout commented Sep 6, 2024

Added a new affliction effect parameter called "ConvulseAmount" which can be used to make characters convulse.

If an affliction's effect has a defined "ConvulseAmount" set to a float higher than zero, it will cause all of the afflicted character's limbs to shake around, similiarly to what happens to characters when they start dying from the husk infection, with the intensity of the shaking depending on the value of "ConvulseAmount".
8mb.video-t7G-FdbHVIC5.mp4

If an affliction's type is "convulse", it will cause all of the afflicted character's limbs to shake around, similiarly to what happens to characters when they start dying from the husk infection.
@SomeRandomNoobKekeke
Copy link

Now make 10 characters "convulse" at once and look at showperf

@TheNinjaScout
Copy link
Author

TheNinjaScout commented Sep 6, 2024

Now make 10 characters "convulse" at once and look at showperf

Video on top shows 10+ characters convulsing around, second one is without the convulse affliction:

8mb.video-HaW-NdlxyPa9.mp4
8mb.video-42H-SOuqW2D0.mp4

@SomeRandomNoobKekeke
Copy link

Hmm weird
I thought this is exact copy of husk transformation, and husk transformation is very laggy
I thought it's laggy because of those convulsions, but perhaps there's some other reason

10.husk.transformations.mp4

@TheNinjaScout
Copy link
Author

Hmm weird I thought this is exact copy of husk transformation, and husk transformation is very laggy I thought it's laggy because of those convulsions, but perhaps there's some other reason

10.husk.transformations.mp4

Here's 10+ characters convulsing due to husk infection, no FPS drop either.
I manually spawned them in through console commands and gave them the affliction- maybe using events to do that causes the lag?

8mb.video-RhL-uXCL8Z0h.mp4

@SomeRandomNoobKekeke
Copy link

SomeRandomNoobKekeke commented Sep 6, 2024

maybe using events to do that causes the lag?

I don't think so

What is 1.5.9.2 unstable? :BaroDev:, is it unstable and they just forgot to change this label? or some custom version?
Mb it's just fixed there

Or maybe you have non potato pc

If you want to be sure you can take this mod, open "a test chamber" sub in sub editor and type triggerevent "husk lag" in console

EDIT:
I went to unstable and indeed husk transformation laggs much less there, so i guess it's just will be fixed
also my unstable is 1.6.4.0
Screenshot_2

@TheNinjaScout
Copy link
Author

What is 1.5.9.2 unstable? :BaroDev:, is it unstable and they just forgot to change this label? or some custom version? Mb it's just fixed there

If you want to be sure you can take this mod, open "a test chamber" sub in sub editor and type triggerevent "husk lag" in console

My "unstable version" is just me building the current repository as "unstable" instead of "release", it should in theory behave exactly the same as the current public steam version of the game, except for the modifications made in this PR. I'll experiment with your mod when I can and see what I can find out- there might be some sort of performance issue that only happens on the release builds an not on unstable.

@SomeRandomNoobKekeke
Copy link

This seems to be caused by luatrauma directly
BaroDev (wide)

Convulsion strength / intensity now depends on the 'ConvulseAmount' float parameter in the current effect of the affliction, giving more control over how much the ragdoll should shake.
@TheNinjaScout TheNinjaScout changed the title Add "convulse" affliction type Add "ConvulseAmount" affliction effect parameter Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants