Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Missing Strings #2153

Merged
merged 78 commits into from
Jan 16, 2025
Merged

Added Missing Strings #2153

merged 78 commits into from
Jan 16, 2025

Conversation

NovaDiablox
Copy link
Contributor

@NovaDiablox NovaDiablox commented Nov 15, 2024 •
edited
Loading

  • Added Missing Strings
  • Deleted Unused String "Creations"
  • Added localization support for the "Other" category (for everything that doesn't have it's own category) in places like the new game menu or ents, sweps and similar tabs.
  • Added localization support for categories in ents, sweps and similar tabs.
  • Added localization support for weapons descriptions labels (not the description itself) in the weapon selector.
  • Added localization support the "New category" option in spawn menu (new category also gets the same localization)

Huge thanks to @Satton2 for helping me improve this PR.

@NovaDiablox NovaDiablox changed the title Added Missing Strings (Texturize Tab) Added Missing Strings Nov 15, 2024
@NovaDiablox NovaDiablox marked this pull request as ready for review November 15, 2024 15:20
@Satton2
Added more missing strings (#1)
44f8860 
* Update spawnmenu.properties

* Update entities.properties

* Update base_vehicles.lua

* Update base_npcs.lua

* Update spawnmenu.properties

* Update npc_tf2_ghost.lua

* Update cl_init.lua

* Update custom.lua

* Update getmaps.lua

* Update entities.lua

* Update npcs.lua

* Update postprocess.lua

* Update vehicles.lua

* Update weapons.lua

* Update edit_sun.lua

* Update edit_sky.lua

* Update edit_fog.lua

* Update game_hl2.lua

* Update sent_ball.lua

* Update weapons.lua

* Update entities.lua

* Update npcs.lua

* Update vehicles.lua

* Update postprocess.lua

* Update weapons.lua

* Update spawnmenu.properties
@robotboy655 robotboy655 added the Enhancement The pull request enhances current functionality. label Nov 20, 2024
@IBRS-4Ever
Copy link
Contributor

IBRS-4Ever commented Nov 28, 2024 •
edited
Loading

Is it possible to localize the "Favorites" string in the map selector (getmaps.lua)?

@Satton2
Copy link
Contributor

Satton2 commented Nov 28, 2024

Is it possible to localize the "Favorites" string in the map selector (getmaps.lua)?

@IBRS-4Ever Yeap, thanks. Just need Tora to get it in the PR: NovaDiablox#2

Satton2 and others added 7 commits November 28, 2024 22:57
@Satton2
Localization: added more missing strings (#2)
ef677d0 
* Localization: added more missing strings

* Localization: added more missing strings

* Localization: added more missing strings

* Localization: added more missing strings
@NovaDiablox
Updating base.fgd to match base branch
a4d160e
@NovaDiablox
Update gmod_hands.lua
e7ecc2a
@NovaDiablox
Update gmod_player_start.lua
6145da0
@NovaDiablox
Update npc.lua
5b8967a
@NovaDiablox
Update player.lua
dc7341b
@NovaDiablox
Update stool.lua
2f3fa7c
@NovaDiablox
Copy link
Contributor Author

You do not need to (manually?) merge new changes to the repository, it is only necessary when GitHub reports that the PR cannot be automatically merged.

Oh sorry about that, its a bad habit of mine to do that.

@IBRS-4Ever
Copy link
Contributor

IBRS-4Ever commented Dec 13, 2024 •
edited
Loading

image
Localize these categories too? Since now the HL2 do have localizations after the 20th Anniversary update.
image

@Satton2
Copy link
Contributor

Satton2 commented Jan 3, 2025

Localize these categories too? Since now the HL2 do have localizations after the 20th Anniversary update.

Hm... while I know that some languages actually localize game's names (mine usually not), I am not sure if this is necessary. Like, if you will look on the Steam store page of the HL2 we will see that the title is not localized (while in description it does) when technically it's possible to localize the name of the game on their store pages.

The same goes for gamemodes names. Like we can actually think about localizing those that are official, which are Sandbox and TTT (not sure about TTT but localizing the name of the Sandbox gamemode is something I would like to see), but not the others like Prop Hunt for example (we will not be able to track any changes in their localizations).

@robotboy655 robotboy655 merged commit 847b6e6 into Facepunch:master Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Satton2 Satton2 Satton2 left review comments

@robotboy655 robotboy655 robotboy655 approved these changes

Assignees
No one assigned
Labels
Enhancement The pull request enhances current functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NovaDiablox @IBRS-4Ever @Satton2 @robotboy655