Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement skypaint matproxy #2107

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Improvement skypaint matproxy #2107

merged 1 commit into from
Jan 17, 2025

Conversation

friztailo
Copy link
Contributor

@friztailo friztailo commented Aug 28, 2024 •
edited
Loading

sky_paint

Entity:GetNetworkVars() replaced with Entity:GetDT...() functions.
Does not create unnecessary tables and does not perform unnecessary iterations over the table of network values in each frame.

benchmark (SysTime):
Entity:GetDT...()	1.6824031256988e-06	1
Entity:Get...()	4.7368874997673e-06	2.8155484422319
Entity:GetNetworkVars()	3.2047187503892e-06	1.9048459322483

@robotboy655 robotboy655 added the Enhancement The pull request enhances current functionality. label Aug 29, 2024
@friztailo
Copy link
Contributor Author

Maybe we should stop creating the table every frame?

robotboy655
robotboy655 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@robotboy655 robotboy655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how it goes back to magic numbers, but given this is a performance intensive area, I will allow it.

@robotboy655 robotboy655 merged commit 1a9022c into Facepunch:master Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robotboy655 robotboy655 robotboy655 approved these changes

Assignees
No one assigned
Labels
Enhancement The pull request enhances current functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friztailo @robotboy655