Skip to content

Commit

Permalink
403 - 503 - 504
Browse files Browse the repository at this point in the history 
403-PERMISSION_DENIED added

503 and 504 removed

According to: camaraproject#54 (comment)
  • Loading branch information
@FabrizioMoggio
FabrizioMoggio authored Jul 11, 2024
1 parent aac5e0d commit f58f50c
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 52 deletions.
44 changes: 17 additions & 27 deletions code/Test_definitions/call-forwarding-signal-every-forwarding.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Feature: CAMARA Call Fowarwing Signal API, v0.1.0 - Operation call-forwardings
#
# Testing assets:
# * A device object identified by a phone number for which the call forwarding service status could be retrieved
# * A device object identified by a phone number for which the ucall forwarding service status could not be retrieved
# * A device object identified by a phone number for which the call forwarding service status could not be retrieved
#
# References to OAS spec schemas refer to schemas specifies in Call_Forwarding_Signal.yaml, version TBD
Background: Common call-forwarding-signal setup
Expand All @@ -22,6 +22,7 @@ Feature: CAMARA Call Fowarwing Signal API, v0.1.0 - Operation call-forwardings
Scenario: Common validations for any success scenario
# Valid testing default request body compliant with the schema
Given the request body property "$.phoneNumber" is set to a valid phone number supported by the service
And the token context refers to the same phone number
And the request body is set to a valid request body
When the HTTP "POST" request is sent
Then the response status code is 200
Expand All @@ -34,6 +35,7 @@ Feature: CAMARA Call Fowarwing Signal API, v0.1.0 - Operation call-forwardings
@call_forwarding_signal_02_call_forwarding_check_not_active
Scenario: retrieve the call forwarding service settings for a given phone number with no forwarding configured
Given the request body property "$.phoneNumber" is set to a valid phone number for which the call forwarding service status could be retrieved
And the token context refers to the same phone number
And the request body is set to a valid request body
When the HTTP "POST" request is sent
Then the response status code is 200
Expand Down Expand Up @@ -85,7 +87,7 @@ Feature: CAMARA Call Fowarwing Signal API, v0.1.0 - Operation call-forwardings

# Generic 401 Error - authentication
@call_forwarding_signal_401.invalid_token
Scenario: Endpoint involked with an ivalid authentication token
Scenario: Endpoint invoked with an ivalid authentication token
Given an invalid authentication token
When the HTTP "POST" request is sent
Then the response status code is 401
Expand All @@ -94,18 +96,28 @@ Feature: CAMARA Call Fowarwing Signal API, v0.1.0 - Operation call-forwardings
And the response property "$.message" contains a user friendly text

# Generic 403 error - insufficient permission
@call_forwarding_signal_403.invalid_context
Scenario: Endpoint involked with an authentication token not valid for the endoint context
@call_forwarding_signal_403.1_permission_denied
Scenario: Endpoint invoked with an authentication token not valid for the endpoint context
Given an access token with an invalid context
When the HTTP "POST" request is sent
Then the response status code is 403
And the response property "$.status" is 403
And the response property "$.code" is "PERMISSION_DENIED"
And the response property "$.message" contains a user friendly text

@call_forwarding_signal_403.2_invalid_context
Scenario: Endpoint invoked with an authentication token referring to a different phone number that the one used in the phoneNumber parameter
Given the token context referring to a phone number
And the request body property "$.phoneNumber" has a different phone number.
When the HTTP "POST" request is sent
Then the response status code is 403
And the response property "$.status" is 403
And the response property "$.code" is "INVALID_TOKEN_CONTEXT"
And the response property "$.message" contains a user friendly text

# Generic 409 error - conflict
@call_forwarding_signal_409.1_already_exists
Scenario: Endpoint involked, by the same API Consumer, for a phone number whose status is already under verification
Scenario: Endpoint invoked, by the same API Consumer, for a phone number whose status is already under verification
Given a pending request for a given phone number
And a the same phone number for a new request
When the HTTP "POST" for the second request is sent before the first request gets an answer
Expand Down Expand Up @@ -153,26 +165,4 @@ Feature: CAMARA Call Fowarwing Signal API, v0.1.0 - Operation call-forwardings
Then the response status code is 501
And the response property "$.status" is 501
And the response property "$.code" is "NOT_IMPLEMENTED"
And the response property "$.message" contains a user friendly text

# Generic 503 error - service unavailable
@call_forwarding_signal_503.service_unavailable
Scenario: The endpoint is invoked with the API Producer Server down
Given the API Producer Server is down
And the endpoint is invoked
When the HTTP "POST" request is sent
Then the response status code is 503
And the response property "$.status" is 503
And the response property "$.code" is "UNAVAILABLE"
And the response property "$.message" contains a user friendly text

# Generic 504 error - request time exceeded
@call_forwarding_signal_504.timout
Scenario: The API Producer is not able to produce a responce in a given time
Given the API Producer Server is busy
And the endpoint is invoked
When the HTTP "POST" request is sent
Then the response status code is 504
And the response property "$.status" is 504
And the response property "$.code" is "TIMEOUT"
And the response property "$.message" contains a user friendly text
37 changes: 12 additions & 25 deletions code/Test_definitions/call-forwarding-signal-unconditional.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Feature: CAMARA Call Fowarwing Signal API, v0.1.0 - Operation unconditional-cal

# Generic 401 Error - authentication
@call_forwarding_signal_401.invalid_token
Scenario: Endpoint involked with an ivalid authentication token
Scenario: Endpoint invoked with an ivalid authentication token
Given an invalid authentication token
When the HTTP "POST" request is sent
Then the response status code is 401
Expand All @@ -83,8 +83,17 @@ Feature: CAMARA Call Fowarwing Signal API, v0.1.0 - Operation unconditional-cal
And the response property "$.message" contains a user friendly text

# Generic 403 error - insufficient permission
@call_forwarding_signal_403.invalid_context
Scenario: Endpoint involked with an authentication token not valid for the endoint context
@call_forwarding_signal_403.1_permission_denied
Scenario: Endpoint invoked with an authentication token not valid for the endopint context
Given an access token with an invalid context
When the HTTP "POST" request is sent
Then the response status code is 403
And the response property "$.status" is 403
And the response property "$.code" is "PERMISSION_DENIED"
And the response property "$.message" contains a user friendly text

@call_forwarding_signal_403.2_invalid_context
Scenario: Endpoint invoked with an authentication token not valid for the endopint context
Given an access token with an invalid context
When the HTTP "POST" request is sent
Then the response status code is 403
Expand Down Expand Up @@ -131,26 +140,4 @@ Feature: CAMARA Call Fowarwing Signal API, v0.1.0 - Operation unconditional-cal
Then the response status code is 429
And the response property "$.status" is 429
And the response property "$.code" is "TOO_MANY_REQUEST"
And the response property "$.message" contains a user friendly text

# Generic 503 error - service unavailable
@call_forwarding_signal_503.service_unavailable
Scenario: The endpoint is invoked with the API Producer Server down
Given the API Producer Server is down
And the endpoint is invoked
When the HTTP "POST" request is sent
Then the response status code is 503
And the response property "$.status" is 503
And the response property "$.code" is "UNAVAILABLE"
And the response property "$.message" contains a user friendly text

# Generic 504 error - request time exceeded
@call_forwarding_signal_504.timout
Scenario: The API Producer is not able to produce a responce in a given time
Given the API Producer Server is busy
And the endpoint is invoked
When the HTTP "POST" request is sent
Then the response status code is 504
And the response property "$.status" is 504
And the response property "$.code" is "TIMEOUT"
And the response property "$.message" contains a user friendly text

0 comments on commit f58f50c

Please sign in to comment.