'return_route' should be used on DeliveryRequest

'return_route' should be used on DeliveryRequest instead of MessageDelivery
FabioPinheiro · Aug 18, 2023 · 6f78639 · 6f78639
1 parent 72e42fc
commit 6f78639
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/did/shared/src/main/scala/fmgp/did/comm/protocol/pickup3/DeliveryRequest.scala b/did/shared/src/main/scala/fmgp/did/comm/protocol/pickup3/DeliveryRequest.scala
@@ -33,7 +33,8 @@ final case class DeliveryRequest(
       id = id,
       to = Some(Set(to)),
       from = Some(from),
-      body = Some(DeliveryRequest.Body(limit = limit, recipient_did = recipient_did).toJSON_RFC7159)
+      body = Some(DeliveryRequest.Body(limit = limit, recipient_did = recipient_did).toJSON_RFC7159),
+      return_route = Some(ReturnRoute.all), // Protocol expect recipient to get reply on the same channel
     )
 }
 object DeliveryRequest {

diff --git a/did/shared/src/main/scala/fmgp/did/comm/protocol/pickup3/MessageDelivery.scala b/did/shared/src/main/scala/fmgp/did/comm/protocol/pickup3/MessageDelivery.scala
@@ -37,7 +37,6 @@ final case class MessageDelivery(
       attachments = Some(
         attachments.toSeq.map(e => Attachment(id = Some(e._1), data = AttachmentDataBase64(Base64.encode(e._2.toJson))))
       ),
-      return_route = Some(ReturnRoute.all), // Protocol expect recipient to get reply on the same channel
     )
 }
 object MessageDelivery {

diff --git a/did/shared/src/main/scala/fmgp/did/comm/protocol/pickup3/MessagesReceived.scala b/did/shared/src/main/scala/fmgp/did/comm/protocol/pickup3/MessagesReceived.scala
@@ -11,7 +11,8 @@ import fmgp.did.comm._
   * {
   *   "id": "123456780",
   *   "type": "https://didcomm.org/messagepickup/3.0/messages-received",
-  *   "body": { "message_id_list": ["123","456"] }
+  *   "body": { "message_id_list": ["123","456"] },
+  *   "return_route": "all"
   * }
   * }}}
   */