Feat: Change which labels are used when looking for the issue to append to, upgrade dependencies. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBH I don't think we need the flag at all, I'd say it is more of a bug and notifier should not modify issues not created by it. Otherwise 👍 from me, thanks! |
It's a new feature; and as such it should be behind a flag :) |
rudo-thomas
changed the title
|
As agreed off github, I dropped the flag and bumped the major version. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that prometheus-gitlab-notifier will also look for the issue labels that it sets on the issue when looking for the issue to append to. Then, one of the issue labels can be removed on the gitlab side and the notifier will stop appending to that issue.
This is a significant change, hence the version bump.
While at it, update the dependencies.