chore: Cleanup setup and base css #27
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "editor.tabSize": 2, | ||
| "editor.detectIndentation": false | ||
| } |
|
There was a problem hiding this comment. At least locally, this page is broken with this PR; everything after the video itself is gone from rendered output
|
|
There was a problem hiding this comment. With the PR there's a weird glitch with the page/nav/header width, which also deletes the right border of the nav old new |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,73 +1,40 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>{{ block "title" . }}{{ default .GitInfo.Subject .Title | default "Welcome to Foulab! - foulab.org" }}{{ end }}</title> | ||
|
|
||
| <link rel="stylesheet" href="/css/default/default.css"> | ||
|
There was a problem hiding this comment. Hmm, I'm not a Hugo expert, so I did a bit of research what's the idiomatic way to reference assets.
I think the idiomatic way is resources.Get + r.RelPermalink, example: https://github.com/luizdepra/hugo-coder/blob/52b14a50f716cb7e69df8d0804f1b68aeec8a08c/layouts/_default/baseof.html#L41 In the short term, it doesn't give us any immediate value. But long-term:
I think it would also make it easier to serve drafts of the site on non-root URLs (eg example.com/foulab-draft/) just by changing a path in a single config file. what do you think about switching to resources API throughout? Maybe let's wait for @0x5c to also chime in. There was a problem hiding this comment. Would it work with a local deployment? A potential developer's workflow could be putting There was a problem hiding this comment. I've tried a few things and I'm basically running into different problems every time. The use of a variable as per the github link just doesn't work at all This gives me an error about I found alternatives for Site.BaseURL that will basically give me the same problem it did. There's something wrong in Hugo itself, because BaseURL as well as urls.absUrl just somehow don't work as expected. So, for example, with the following code: And running Running with a And without a port specified, letting the default, I just get a default port like All in all, my point here is that Hugo's system is pretty broken, and honestly, the only situation right now where this would matter would be if the baseURL somehow isn't on the root of the domain. BaseURLs really only matter when you're on some subfolder in a more complex configuration or if you're on a share hosting where you can't be on the root. Basically, getting frustrated over trying to go around Hugo's broken system just to fix a non-problem isn't how I want to spend my days 🤣 There was a problem hiding this comment.
Using There was a problem hiding this comment.
Most trivially, considering we already have to use that tool to build the site; It looks though like there might be a bug in hugo or holes in our config/shortcodes; gohugoio/hugo#8896 and related forum thread |
||
| <link rel="stylesheet" href="/css/default/app.css"> | ||
|
|
||
| <link rel="shortcut icon" href="/favicon.ico" type="image/vnd.microsoft.icon"> | ||
| <meta property="og:image" content="/img/logo.png"> | ||
| <meta property="og:image:type" content="image/png"> | ||
| <meta property="og:image:width" content="1124"> | ||
| <meta property="og:image:height" content="1126"> | ||
| <script type="module" src="/js/status.js"></script> | ||
| <script src="/js/sparkles/twgl-full.min.js"></script> | ||
| <script src="/js/sparkles/static.js"></script> | ||
| <script src="/js/sparkles/clouds.js"></script> | ||
| <script src="/js/sparkles/init.js" defer></script> | ||
| </head> | ||
|
|
||
| <body> | ||
| <canvas id="gl_canvas_bg"></canvas> | ||
| <div id="main"> | ||
| {{ partial "header.html" . }} | ||
| <div id="content-wrapper"> | ||
| <div id="content"> | ||
| <div class="content-headline"> | ||
| {{ block "headline" .}}<b>{{ index .Params "topic" | default "foulab.org" }}</b> / {{ index .Params "headline" | default "Welcome to Foulab!" }}{{ end }} | ||
| </div> | ||
| {{ block "main" . }}{{ end }} | ||
| </div> | ||
| {{ partial "navigation.html" . }} | ||
| </div> | ||
| {{ partial "footer.html" . }} | ||
| </div> | ||
| {{ partial "wisdom.html" . }} | ||
|
|
||
| </body> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,10 @@ | ||
| <div style="display: flex; flex-direction: column; gap: 2px; margin-bottom: 2em; border-bottom: 1px solid #4a4a4a; padding-bottom: 0.5em;"> | ||
| <span class="ntitle"> | ||
| <a href="{{ .Permalink }}"> | ||
| {{ default .GitInfo.Subject .Title }} | ||
| </a> | ||
| </span> | ||
| <span class="ntrace">by [{{ default .GitInfo.AuthorName .Params.author_name }}] @ {{ .Lastmod.Format "2006-01-02 15:04:05 -0700" }}</span> | ||
| </div> | ||
|
|
||
| {{ .Content }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,14 @@ | ||
| <div id="footer"> | ||
| <a href="http://jigsaw.w3.org/css-validator/" title="Valid CSS"> | ||
| <img src="/img/valid_css_80x15.png" alt="Valid CSS"> | ||
| </a> | ||
| <a href="http://www.w3.org/WAI/WCAG1A-Conformance" title="Level A conformance icon, W3C-WAI Web Content Accessibility Guidelines 1.0"> | ||
| <img src="/img/valid_wai-a_80x15.png" alt="Level A conformance icon, W3C-WAI Web Content Accessibility Guidelines 1.0"> | ||
| </a> | ||
| <a href="http://creativecommons.org/licenses/by-nc/3.0/" title="Creative Commons Non-commercial License with Attribution 3.0"> | ||
| <img src="/img/license_cc_80x15.png" alt="Creative Commons Non-commercial License with Attribution 3.0"> | ||
| </a> | ||
| <img src="/img/madeinquebec_80x15.png" alt="Made in Quebec" title="Made in Quebec"> | ||
| <div>Except where otherwise noted, content on this site is licensed under a Creative Commons Non-Commercial with Attribution 3.0 License. | ||
| <a href="http://creativecommons.org/licenses/by-nc/3.0/">Creative Commons Non-commercial Attribution 3.0 License</a></div> | ||
| </div> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,38 @@ | ||
| <div id="header"> | ||
| <canvas id="gl_canvas"></canvas> | ||
|
|
||
| <div id="status"> | ||
| STATUS | ||
| <span style="font-size:8px;font-family:monospace;white-space:pre;"> | ||
| ██████ ██████ ███████ ███ ██ | ||
| ██ ██ ██ ██ ██ ████ ██ | ||
| ██ ██ ██████ █████ ██ ██ ██ | ||
| ██ ██ ██ ██ ██ ██ ██ | ||
| ██████ ██ ███████ ██ ████ | ||
| </span> | ||
| </div> | ||
|
|
||
| <div class="tinybar"> | ||
|
|
||
| <a href="https://github.com/FOULAB" title="Foulab GitHub"> | ||
| <img class="icons" src="/img/git.png" alt="Link to Foulab GitHub"> | ||
| </a> | ||
| <a href="https://web.libera.chat/?channels=#foulab" title="IRC Webchat"> | ||
| <img class="icons" src="/img/irc.png" alt="Link to IRC Webchat"> | ||
| </a> | ||
| <a href="https://twitter.com/foulab" title="Twitter"> | ||
| <img class="icons" src="/img/twt.png" alt="Link to Twitter"> | ||
| </a> | ||
| <a href="/news/index.xml" title="RSS Feed"> | ||
| <img class="icons" src="/img/rss.png" alt="Link to RSS Feed"> | ||
| </a> | ||
| <a href="mailto:[email protected]" title="Mailing List"> | ||
| <img class="icons" src="/img/eml.png" alt="Link to Mailing List"> | ||
| </a> | ||
|
Comment on lines
+29
to
+31
There was a problem hiding this comment. Definitely not a question I can personally answer 😓 There was a problem hiding this comment. Looks like it's been there since inception of the Hugo version of the site, 6 years ago: I don't have any tacit knowledge about this, I don't have admin access to that mailing list, if it even still exists. So I suggest deleting this. Thanks for checking. There was a problem hiding this comment. Looking on riseup's list server, it seems there's no longer a list with that name. Should be safe to remove |
||
| <a href="https://www.facebook.com/groups/144161830009" title="Facebook Group"> | ||
| <img class="icons" src="/img/fb.png" alt="Link to Facebook Group"> | ||
| </a> | ||
|
|
||
| </div> | ||
|
|
||
| </div> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be best to avoid commiting local editor-specific configs to a public repo.
It will create conflicts for anyone who has to locally edit theirs
For those settings which are relevant to style, using EditorConfig is the normal way to automatically communicate them to editors. It is supported out of the box by numerous editors, including VSCode