Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7.1 #5

Merged
merged 13 commits into from
Jun 6, 2024
Merged

Support Symfony 7.1 #5

merged 13 commits into from
Jun 6, 2024

Conversation

rey26
Copy link
Contributor

@rey26 rey26 commented Jun 5, 2024

  • add missing support for Symfony 7.1

rey26 and others added 2 commits June 5, 2024 13:03
@Prometee
Copy link
Member

Prometee commented Jun 5, 2024

@rey26 I added the missing build tests for Symfony 7.1, lets see if everything is going well.

@Prometee
Copy link
Member

Prometee commented Jun 5, 2024

It breaks because of a dev requirements from one of my own php package, I will add support to Sf 7 inside it and relaunch the build.

@Prometee
Copy link
Member

Prometee commented Jun 5, 2024

I expect this to happen one day :

PHP Fatal error:  Class FluxSE\OdooApiClient\Serializer\OdooNormalizer cannot extend
final class Symfony\Component\Serializer\Normalizer\ObjectNormalizer in
src/Serializer/OdooNormalizer.php on line 15

It needs to be refactored, do you see how to fix this ? I build it this way because I don't wanted to copy/paste the entire Symfony ObjectNormalizer. Maybe now there is another way of handling it.

@Prometee Prometee force-pushed the 4-support-symfony-71 branch 2 times, most recently from ec4d3a0 to 3c63c9e Compare June 5, 2024 15:21
@Prometee Prometee force-pushed the 4-support-symfony-71 branch from 3c63c9e to 69e7b51 Compare June 5, 2024 15:24
@Prometee
Copy link
Member

Prometee commented Jun 5, 2024

@rey26
I tried to fix the issues but a bug in the symfony/serializer is triggering an error:

Error: Call to undefined function is_false()

vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:780
vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:380
src/Serializer/OdooNormalizer.php:35
vendor/symfony/serializer/Serializer.php:238
vendor/symfony/serializer/Normalizer/ArrayDenormalizer.php:74
vendor/symfony/serializer/Serializer.php:238
src/Manager/ModelListManager.php:56
src/Manager/ModelListManager.php:31
tests/Manager/ModelListManagerTest.php:44

PS: If you want to commit changes, don't forget to pull changes before.

@Prometee Prometee force-pushed the 4-support-symfony-71 branch from 70e6163 to 739beb3 Compare June 5, 2024 15:55
@Prometee Prometee changed the title 4 - Support Symfony 7.1 Support Symfony 7.1 Jun 6, 2024
@Prometee
Copy link
Member

Prometee commented Jun 6, 2024

@rey26 the issue with symfony/serializer has been fixed but not yet merged into a stable branche nor tag yet.
And here is the related issue to symfony/serializer : symfony/symfony#57334

I will merge this PR to fix #4 and then create a new major version since I remove support of symfony 5.4 packages.

@Prometee Prometee merged commit b9cf778 into FLUX-SE:master Jun 6, 2024
26 checks passed
@rey26
Copy link
Contributor Author

rey26 commented Jun 7, 2024

@Prometee thanks for all of that, I was very busy these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants