Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StripeClient class #37

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Use StripeClient class #37

merged 4 commits into from
Sep 19, 2023

Conversation

Prometee
Copy link
Member

@Prometee Prometee commented Sep 19, 2023

stripe/stripe-php has evolved since v9, this PR aim to support newer version : v12.

This PR also add support for new options :

  • client_id
  • stripe_account
  • stripe_version

Those new options are supported to be able to control the StripeClient : https://github.com/stripe/stripe-php/blob/master/lib/BaseStripeClient.php#L19-L21

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #37 (cf4e5c3) into master (be39460) will decrease coverage by 1.53%.
The diff coverage is 88.26%.

❗ Current head cf4e5c3 differs from pull request most recent head 7819bea. Consider uploading reports for the commit 7819bea to get more accurate results

@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
- Coverage     99.85%   98.32%   -1.53%     
- Complexity      428      490      +62     
============================================
  Files           110      121      +11     
  Lines          1348     1491     +143     
============================================
+ Hits           1346     1466     +120     
- Misses            2       25      +23     
Files Changed Coverage Δ
src/Api/StripeClientAwareTrait.php 25.00% <25.00%> (ø)
src/Action/Api/Resource/AbstractDeleteAction.php 90.00% <66.66%> (-10.00%) ⬇️
src/Action/Api/Resource/AbstractAllAction.php 94.11% <75.00%> (-5.89%) ⬇️
src/Action/Api/Resource/AbstractCreateAction.php 94.11% <75.00%> (-5.89%) ⬇️
src/Action/Api/Resource/AbstractRetrieveAction.php 94.11% <75.00%> (-5.89%) ⬇️
src/Action/Api/Resource/AbstractUpdateAction.php 94.44% <75.00%> (-5.56%) ⬇️
src/AbstractStripeGatewayFactory.php 100.00% <100.00%> (ø)
src/Action/Api/Resource/AllCouponAction.php 100.00% <100.00%> (ø)
src/Action/Api/Resource/AllCustomerAction.php 100.00% <100.00%> (ø)
src/Action/Api/Resource/AllInvoiceAction.php 100.00% <100.00%> (ø)
... and 49 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Prometee Prometee merged commit 8949938 into master Sep 19, 2023
10 checks passed
@Prometee Prometee deleted the php-stripe-v12 branch September 19, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant