Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<sync>(code): sync code from master. #845

Merged
merged 127 commits into from
Apr 28, 2024
Merged

<sync>(code): sync code from master. #845

merged 127 commits into from
Apr 28, 2024

Conversation

kyonRay
Copy link
Member

@kyonRay kyonRay commented Apr 28, 2024

No description provided.

kyonRay and others added 30 commits September 5, 2022 16:37
<fix>(compiler): fix compiler switch version static final optimization bug.
…-BCOS#680)

* <fix>(precompiled): fix bfs list /sys/ contracts bugs.

* <fix>(completer): fix deploy liquid bug.
…e. (FISCO-BCOS#681)

* <fix>(completer,precompiled): fix deploy liquid completer bug. (FISCO-BCOS#680)

* <fix>(precompiled): fix bfs list /sys/ contracts bugs.

* <fix>(completer): fix deploy liquid bug.

* <feat>(contract): add deploy link feature, add listAbi address feature.
* <test>(CI): add github actions.

* <fix>(CI,crud): fix crud parseSQL error.
<release>(project): Release 3.1.0.
kyonRay and others added 25 commits December 15, 2023 17:31
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

TransactionResponse transactionResponse =
deployWasm(binPath, abiPath, path, inputParams);
address = transactionResponse.getContractAddress();
abiString = FileUtils.readFileToString(new File(abiPath));

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
FileUtils.readFileToString
should be avoided because it has been deprecated.
if (supportedVersion.compareTo(EnumNodeVersion.BCOS_3_1_0.toVersionObj()) >= 0) {
fileInfoList = bfsService.list(listPath, offset, Common.LS_DEFAULT_COUNT);
} else {
fileInfoList = new Tuple2<>(BigInteger.ZERO, bfsService.list(listPath));

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
BFSService.list
should be avoided because it has been deprecated.
logger.debug(
"compileSolToBinAndAbi, solc version:{} ,basePath: {}",
ContractCompiler.solcJVersion,
solFile.getParentFile().getCanonicalPath());

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files High

This
potentially sensitive information
is written to a log file.

void linkShard(String[] params) throws Exception;

void fixBFS(String[] params) throws Exception;

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'params' is never used.
}
}

public void transferBalance(String[] params) throws Exception {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
PrecompiledFace.transferBalance
; it is advisable to add an Override annotation.
@kyonRay kyonRay merged commit c138fd9 into FISCO-BCOS:dev Apr 28, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants