-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hla normalization #107
Conversation
rebase the branch
…ics-operations into add-hla-normalization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one Bob! There's just one small issue with initialising pyard in both app/common.py
and app/utilities_endpoints.py
. We should move that code somewhere in utilities
, maybe in a new .py
file.
app/common.py
Outdated
pyard_database_version = os.getenv('PYARD_DATABASE_VERSION', '3580') | ||
ard = pyard.init(data_dir='./data/pyard', cache_size=1, imgt_version=pyard_database_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to do this in a single place to avoid duplication and having it loaded multiple times in memory. It's probably better to have a .py
file for it in the utilities folder and have a wrapper function for
ard.redux()` in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a stab at fixing this in d6b6121.
Description
app/common.py
app/endpoints.py
add / revise test cases