Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fesom2.5 intel fixes #442

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fesom2.5 intel fixes #442

wants to merge 5 commits into from

Conversation

trackow
Copy link
Contributor

@trackow trackow commented Mar 23, 2023

Test to see it worked...

@JanStreffing JanStreffing added this to the FESOM 2.6 milestone Feb 28, 2024
@JanStreffing
Copy link
Collaborator

@trackow Does this still make sense to merge for 2.6?

@JanStreffing
Copy link
Collaborator

@trackow Any update on this PR?

@trackow
Copy link
Contributor Author

trackow commented Mar 13, 2024

The io_meandata.F90 changes by Dima and the added k-loop in oce_fer_gm.F90 I don't know what they are for, but we should check with him @dsidoren .

 !Intel vectorisation did something strange in the above lines hence we had to code it more explicitely
        nzmax=mesh%nl
        nzmin=1
        do k=1, nod_in_elem2D_num(n)
           nzmax=min(nzmax, nlevels(nod_in_elem2D(k, n)))
           nzmin=max(nzmin, ulevels(nod_in_elem2D(k, n)))
        end do

The rest, for example, MPI_BARRIERs and OMP barriers I would not touch as they worked well in https://github.com/FESOM/fesom2/tree/2.5.0.3_de. So would again suggest to just merge that branch instead

@JanStreffing
Copy link
Collaborator

We leave this open until after merge of #571 and check what's left then. @patrickscholz said the io_meandata changes might be good still and not covered elsewhere.

@JanStreffing JanStreffing modified the milestones: FESOM 2.6, FESOM 2.7 Jun 11, 2024
@JanStreffing JanStreffing changed the base branch from refactoring to main June 21, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants