Fix bug in freshwater balancing and drifting ocean volume when using icepack #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h icepack and zstar without crashing. However, FW is still not conserved as it should, and restarts fail when the model is run at high resolution... Not sure why this is.
…e_therm2, commented contribution from thermodyn. growth rates only leave contributions from evap, frain and snow in moment
…aibles are updated so changes in the namelist parameter update_ocn_f find its way into the internal variables of icepack
…rwise icepack internal variable update_ocn_f could not be updated from default .false. into namelist .true. (was a realy weird thing)
…s the unints from fesom2icepack but also from icepack2fesom
…pack add its snow based on the newly formed ice while our standard ice model add the freshwater contribution from snowfall based on the ice concentration of the previous time step (a_ice_old)
…o will also add another feature so the aggregation of the varaibles at the beginning will not have to be done every timestep
…dencies initialization only at the first timestep to spare computations
…now imported from FESOM2
…ixpscholz instead of icepack_fesom2! This is very important to guarantee freshwater conservation.
…serving the freshwater.
koldunovn
reviewed
Oct 1, 2021
src/ice_setup_step.F90
Outdated
| @@ -31,6 +31,7 @@ subroutine ice_setup(mesh) | |||
| ice_dt=real(ice_ave_steps,WP)*dt | |||
| ! ice_dt=dt | |||
| Tevp_inv=3.0_WP/ice_dt | |||
| Tevp_inv=1.0_WP/1800.0_WP | |||
There was a problem hiding this comment.
That's a bit too radical :) We will have to make it a switch to be able to keep old behaviour.
There was a problem hiding this comment.
Hey @koldunovn! Agreed... I was just testing something on the branch and I forgot there was a pull request open associated with it! I will switch to a different branch and revert this change.
There was a problem hiding this comment.
Nice to see you back in the FESOM2 repo! :)
There was a problem hiding this comment.
Yes, I gave myself a couple of days to clean a bit of the mess I left behind ;)
|
Master is no longer default. Can not be merged for 2.6. Shall be redone for 2.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a variety of bugs in the FESOM2 - ICEPACK interface but also in ICEPACK itself (which is outsourced into branch icepack_fesom2_fixpscholz within the ICEPACK repository), so that we are able to fully balance the freshwater fluxes in FESOM2 zstar case and the ocean volume remains constant and does not drift away.
Of course with these changes the actual icepack github testcase will fail but the changes have no influence on the actual default case !