Skip to content

Commit

Permalink
avoid race condition that could corrupt user stack if DOS re-entered …
Browse files Browse the repository at this point in the history
…too soon

apply suggested fix from SF bug 215 (https://sourceforge.net/p/freedos/bugs/215/), InDOS cleared but small chance DOS re-entered before user stack restored thus corrupting user stack
  • Loading branch information
PerditionC committed Aug 19, 2024
1 parent dabfaf7 commit 1cc00e1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion kernel/entry.asm
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ int21_normalentry:
push bp
call _int21_service

int21_exit: dec byte [_InDOS]
int21_exit:
%IFDEF WIN31SUPPORT
call end_dos_crit_sect ; release all critical sections
%if 0
Expand All @@ -417,6 +417,10 @@ int21_exit: dec byte [_InDOS]
%endif
%ENDIF ; WIN31SUPPORT

; tiny chance DOS re-entered between clearing InDOS and restoring user stack,
; so we disable interrupts until user stack restored; see SF bug# 215
cli
dec byte [_InDOS]
;
; Recover registers from system call. Registers and flags
; were modified by the system call.
Expand Down

0 comments on commit 1cc00e1

Please sign in to comment.