feat: progress bar in my sites #1189
Conversation
Signed-off-by: Luke McFarlane <[email protected]>
Signed-off-by: Luke McFarlane <[email protected]>
Signed-off-by: Luke McFarlane <[email protected]>
Signed-off-by: Luke McFarlane <[email protected]>
|
@PeterBaker0 issues above resolved |
Signed-off-by: Peter Baker <[email protected]>
| useEffect(() => { | ||
| const getData = async () => { | ||
| try { | ||
| if (query.length === 0) { | ||
| const ma = await getMetadataForAllRecords( | ||
| props.project_id, | ||
| props.filter_deleted | ||
| ); | ||
| setPouchData(ma); | ||
| } else { | ||
| const ra = await getRecordsWithRegex( | ||
| props.project_id, | ||
| query, | ||
| props.filter_deleted | ||
| const records = ( | ||
| query.length === 0 | ||
| ? await getMetadataForAllRecords( | ||
| props.project_id, | ||
| props.filter_deleted | ||
| ) | ||
| : await getRecordsWithRegex( | ||
| props.project_id, | ||
| query, | ||
| props.filter_deleted | ||
| ) | ||
| ) as RecordMetaDataExtended[]; | ||
|
|
||
| for (const record of records) { | ||
| const data = await getFullRecordData( | ||
| record.project_id, | ||
| record.record_id, | ||
| record.revision_id | ||
| ); | ||
| setPouchData(ra); | ||
|
|
||
| if (!data) continue; | ||
|
|
||
| record.record = data; | ||
| } | ||
|
|
||
| setPouchData(records); |
There was a problem hiding this comment.
Is this is probably going to conflict with my pending PR #1199 which moves this into a react query - but that's okay we can fix it up
| for (const record of records) { | ||
| const data = await getFullRecordData( | ||
| record.project_id, | ||
| record.record_id, | ||
| record.revision_id | ||
| ); |
There was a problem hiding this comment.
Performance concerns here possibly - but we'll see.
There was a problem hiding this comment.
For the PR to display summary fields in the record table we'll be grabbing the whole record data so this would not be necessary. A few interacting changes going on here. Can this be deferred?
There was a problem hiding this comment.
Yes, we can defer this one
app/src/lib/queries.ts
Outdated
There was a problem hiding this comment.
cool - I think there is a space for hooks already though
|
Not what you're doing here but your earlier progress bar breaks the rules by updating the parent component (Record) while rendering the child RecordForm. The call to setProgress in RecordForm.render is the problem, it needs to move out of render and into one of the other methods. See the console when you render a form for the warning. |
JIRA Ticket
BSS-375
Description
Added progress bar to sites table in mobile view.
Proposed Changes
How to Test
Additional Information
Checklist