-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: back button #1178
base: main
Are you sure you want to change the base?
feat: back button #1178
Conversation
…dded config to switch between them Signed-off-by: Luke McFarlane <[email protected]>
Signed-off-by: Luke McFarlane <[email protected]>
Signed-off-by: Luke McFarlane <[email protected]>
Signed-off-by: Luke McFarlane <[email protected]>
Behaviour after creating a child record is probably not intuitive. Back takes me back to the child record I just edited and closed which makes sense since that was the last place I was at but how does the user then navigate up to the notebook at that point? Back button doesn't give the same functionality as the breadcrumbs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the answer here is to have the 'back' link be the last link in the breadcrumb chain suitably labelled. 'Back to Notebook', 'Back to Site' etc if you can work out those names at the same time as you're working out the human readable names for the breadcrumb links.
</Typography> | ||
); | ||
})} | ||
<Box display="flex" flexDirection="row-reverse"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to use human readable names rather than identifiers for the notebook/form/record eg. what we used to have: "Notebooks / Campus Survey Demo / Survey Area: Zone Beta; Some area / Element: Rubbish bin-00030"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also these breadcrumb entries aren't links and you have a fixed number of them rather than being driven by the data prop - if we're in a Building then there would be four levels of breadcrumb Home > Survey > Site > Building.
Signed-off-by: Luke McFarlane <[email protected]>
Signed-off-by: Luke McFarlane <[email protected]>
JIRA Ticket
BSS-389
Description
Added the option to have a back button within the app as well as fixing the current breadcrumb implementation to work on all screens.
Proposed Changes
How to Test
VITE_NAVIGATION=breadcrumbs
to your.env
file.env
to haveVITE_NAVIGATION=back-button
and repeat steps 2 and 3Additional Information
Checklist