-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix movement effect warning spam due to Spearhead (XEL0306) #6552
Conversation
@BlackYps Would this be possible to merge in before release? I've added its PR number to the 6436 snippet in that case, but otherwise it should be separate. |
-- warning isn't needed if this layer's table is used for Footfall or Contrails without terrain effects | ||
if not bpTable.Footfall and not bpTable.Contrails then | ||
-- warning isn't needed if this layer's table is used for Footfall or Contrails or Treads without terrain movement effects | ||
if not bpTable.Footfall and not bpTable.Contrails and not bpTable.Treads then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point perhaps it is more readable as not (X or Y or Z)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur with Jip
Yes, this sounds good to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, errors are eliminated (I only tested the Spearhead, not sure what other units were throwing the error, but solution applies universally).
Description of the proposed changes
Testing done on the proposed changes
Look at the spearhead's treads and make sure they work and aren't disconnected visually.
Checked all blueprints that could trigger the warning using this command:
Output only has `Contrails`, `Footfall`, and `Treads`
Additional context
Checklist