Fix billy nuke launches being synced to UI #6546
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
An exploit that @clyfordv's mod discovered, where you can be notified of enemy billy nuke launches because the launch data is synced despite not having a VO line play.
Description of the proposed changes
Fixes the exploit by adding the VO's condition from
Unit.NukeCreatedAtUnit
to the launch data sync condition. Allies still get pings for billy nukes.Testing done on the proposed changes
Log the data that is synced when a nuke launches:
Additional Context
There is currently no visual indicator for strategic launches by default, but it can be modded in.
Effectively a continuation of the anti-cheat logic in #5582.
Checklist