Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix billy nuke launches being synced to UI #6546

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Nov 19, 2024

Issue

An exploit that @clyfordv's mod discovered, where you can be notified of enemy billy nuke launches because the launch data is synced despite not having a VO line play.

Description of the proposed changes

Fixes the exploit by adding the VO's condition from Unit.NukeCreatedAtUnit to the launch data sync condition. Allies still get pings for billy nukes.

Testing done on the proposed changes

Log the data that is synced when a nuke launches:

  • Allies/yourself/observers receive data + location data of billy nukes and nukes
  • When switching to an enemy army before launching the nuke, you receive data only for nukes and no data at all for billy nukes.

Additional Context

There is currently no visual indicator for strategic launches by default, but it can be modded in.
Effectively a continuation of the anti-cheat logic in #5582.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

The launch data would be sent despite no global VO being played
In the past, it was more complicated to make use of the `NuclearLaunchInitiated` audio field
This reverts commit f8cc667.
@lL1l1 lL1l1 added type: bug area: sim Area that is affected by the Simulation of the Game labels Nov 19, 2024
@lL1l1 lL1l1 added this to the Development I of 2025 milestone Nov 19, 2024
@lL1l1 lL1l1 marked this pull request as ready for review November 19, 2024 16:39
@clyfordv clyfordv self-assigned this Nov 26, 2024
Copy link
Contributor

@clyfordv clyfordv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, changes are good, notifications work as expected for billy and non-billy nukes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Area that is affected by the Simulation of the Game type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants