Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Aeon SACU Enhancement Script #6516

Merged
merged 13 commits into from
Nov 19, 2024
Merged

Update Aeon SACU Enhancement Script #6516

merged 13 commits into from
Nov 19, 2024

Conversation

MrRowey
Copy link
Member

@MrRowey MrRowey commented Nov 7, 2024 •
edited
Loading

Following on the changes of #6498

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

Garanas
Garanas requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in the basic annotations, see also:

@MrRowey MrRowey marked this pull request as draft November 11, 2024 13:29
@MrRowey MrRowey marked this pull request as ready for review November 11, 2024 21:00
@MrRowey MrRowey requested a review from Garanas November 11, 2024 21:00
Garanas
Garanas requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I spawn in the SACU presets I get the following warning:

WARNING: Missing enhancement: 	EngineeringFocusingModule	 for unit: 	ual0301_engineer	 note that the function name should be called: 	ProcessEnhancementEngineeringFocusingModule

@lL1l1 lL1l1 added the area: code style code refactoring label Nov 18, 2024
@lL1l1 lL1l1 requested a review from Garanas November 18, 2024 17:39
@MrRowey
Copy link
Member Author

MrRowey commented Nov 19, 2024

@Garanas can this be merged in please

@Garanas Garanas merged commit 7163f73 into FAForever:develop Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garanas Garanas Garanas approved these changes

Assignees
No one assigned
Labels
area: code style code refactoring
Projects
None yet
Milestone
Development iteration III of 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@MrRowey @Garanas @lL1l1