Rework the matchmaker lobby (autolobby) #6479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any mods that might affect lobby in a way that needs special considerations / testing? |
|
A UI mod does not work/apply during the lobby. The only thing that can adjust the lobby are featured mods. That would be co-op and Nomads. But neither of them touch the autolobby file 😄 ! |
lL1l1
reviewed
Oct 19, 2024
There was a problem hiding this comment.
I like the new design for the autolobby overall. Getting the communication stuff out of the way paves a way for an easier time making improvements like the ones in kyro's lobby that people were a fan of before we unfortunately had to disable it.
By the way remember to use the ReusedLayoutFor.
`AutolobbyMessages.lua` now document what messages exist and how/when they are accepted. To prevent too much coupling with the controller we simplified the handler to just be a wrapper to a function inside the lobby.
When running locally the peer Ids line up nicely. However, in practice the peerIds can be all over the place and can not be easily mapped to a number. Therefore we manually keep track of them and map them to a number so that we can visualize it.
This prevents all connections being established at roughly the same time.
This reverts commit 92ab7f4.
It requires more testing. Eventually it should likely be the host that informs a client to rejoin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Reworks the matchmaker lobby from the bottom up with a focus on documentation and a better maintainable code structure. Introduces a similar setup to the MVC pattern. The pattern is simplified. This is an automated lobby and therefore the view never has to communicate back to the controller.
Controller/Model
See also:
lua\ui\lobby\autolobby\AutolobbyController.lualua\ui\lobby\autolobby\AutolobbyMessageHandlers.luaIs responsible for the functionality of the matchmaker lobby. This involves creating the initial state and syncing this state between players.
View (interface)
See also:
lua\ui\lobby\autolobby\AutolobbyMapPreview.lualua\ui\lobby\autolobby\AutolobbyInterface.luaResponsible for the interface of the user. Note that the interface has support for a basic version of hot reload. You can make changes to the interface and it will try to re-initialize in real time. There is no need to restart the application.
The map preview is created from the ground up too with performance (allocations) in mind.
Testing done on the proposed changes
With thanks to the script made by @lL1l1 in #6474 you can run the changes locally and inspect the result. The game launches. The host shares the settings. And once everyone is connected we launch the game.
Rejoin functionality at 1482163
autolobby-08.mp4
d41177b
autolobby-06.mp4
320f9f4
autolobby.mp4
Additional context
The interface of the matchmaker lobby has support for a basic 'hot reload' functionality. Assuming that you programmatically blocked the launch you can make changes to the interface, save the file, and the game will automatically try to re-initialize the interface. There's a snippet of comments for at the top of
lua\ui\lobby\autolobby\AutolobbyInterface.luathat explains in more detail about how it works.Checklist
Issues
Resolved with: e9670d3
Resolved with: 5823e21
Existing features
MakeValidPlayerName)GpgNetSendin the old autolobby. In paritcular theLaunchStatus,GameState,DisconnectedandPlayerOptionkeys that are sent.New features
New features to be discussed
Cancelled features
PreGamedataas defined in the regular lobby.We either have this feature, or prefetching. We can't have both. Since you can not choose your UI mods regardless, it is probably best to just use whatever is in the prefs file at that moment and use prefetching instead.