Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate auto assist in InitialAutoMode and SetAutoMode #6218

Merged

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented May 28, 2024

Testing done on the proposed changes

  • Toggling off InitialAutoMode for hives disables their automatic assistance. Weirdly enough the production toggle on hives doesn't actually toggle auto mode (through SetAutoMode), but it toggles whether auto mode can act or not.
  • Toggling off InitialAutoMode for drones and the base station simultaneously toggles off automatic assistance.
  • It's already known that auto mode toggles automatic silo building.

Other

I'm not sure what the exact requirements for a unit to be able to automatically assist are. The unit also only auto assists within its GuardScanRadius. The ENGINEERSTATION STATIONASSISTPOD PODSTAGINGPLATFORM categories seem important. Mainly STATIONASSISTPOD since it is on kennel drones and hives.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added the area: code style code refactoring label May 28, 2024
@lL1l1 lL1l1 changed the title Annotate InitialAutoMode Annotate auto assist in InitialAutoMode and SetAutoMode May 28, 2024
@MrRowey MrRowey merged commit fb6fe4a into FAForever:deploy/fafdevelop May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: code style code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants