Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatboy unit detach bug + exFac footprint fix #6192

Merged
merged 5 commits into from
May 25, 2024

Conversation

clyfordv
Copy link
Contributor

Issues:

  1. Ordering "deploy" on the Fatboy will detach the unit under construction
  2. External factory dummy anchorUnits had a lingering footprint in the blueprint that blocked structure construction (minor, but aesthetically bad)

Fixes:

  1. Add a check in the fatboy script to make sure the detaching unit is complete--this could be generalized, but the fatboy is the only unit with this issue, and I believe it also has specific factory attach bone requirements
  2. Trim the anchor unit blueprint to remove footprint + additional unnecessary values

Afterthoughts:

  1. Anchor dummy unit still necessary to prevent selecting the exFac from the worldview

@MrRowey MrRowey added type: bug feature: mobile factories related to mobile factory functionality labels May 16, 2024
@@ -0,0 +1 @@
(#6192) Removes an erroneous exFac dummy unit structure footprint, and prevents the fatboy from detaching units under construction when "deploy" is ordered.
Copy link
Member

@Garanas Garanas May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you turn this into two lines, e.g.:

(#6192) Removes an erroneous structure footprint from the dummy unit of external factories

(#6192) Fix a bug where deploying when building a unit in the external factory would detachg the unit under construction 

This primarily applies to the Fatboy.

That makes it easier to read 😃

Copy link
Contributor

@lL1l1 lL1l1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit inside the mobile factory still blocks construction. I guess that's unfixable?

@clyfordv
Copy link
Contributor Author

I was unaware of that, but I'm guessing it has to do with the build area needing to be free etc. etc. We could chase that goose but I think the return would be minimal, I was mostly worried about the little square popping up (which looked scuffed).

@Garanas Garanas merged commit 0298a8e into FAForever:deploy/fafdevelop May 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile factories related to mobile factory functionality type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants