This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Re-inserted a rm statement for firstboot file #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: Fixes F5Networks#75 Problem: * The firstboot is given to the BIG-IP from onboarding * After the initial, firstboot init cycle, this file should be removed * Without it's removal config collisions could occur * Without it's removal reboot cycles take longer Analysis: * This inserts the removal statement after all first boot inits Tests: None. This is a startup scripting for onboarding. While we have some tests in regards to this, it would be very difficult to tell whether or not the first boot init was done twice after a reboot.
ssorenso
force-pushed
the
bugfix.liberty.firstboot_file_removal_26
branch
from
8437f81 to
1c41271
Compare
pjbreaux
approved these changes
Jul 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Fixes #75
Problem:
Analysis:
Tests:
None. This is a startup scripting for onboarding. While we have some
tests in regards to this, it would be very difficult to tell whether or
not the first boot init was done twice after a reboot.
Assignee:
@richbrowne
Reviewers:
@pjbreaux
What this change addresses:
This change will delete the
/config/firstbootfile introduced by the onboarding scripting. This will prevent subsequent boot sessions from performing the initial boot cycle, which costs time and resource preventing the BIG-IP from booting as quickly.Where should the reviewer start:
This is a simple change and only adds 1 if/then statement. This should be the focus.