Catch ASG error

F5Networks · Sep 27, 2019 · 7e21708 · 7e21708
1 parent 49db0cb
commit 7e21708
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/app/waf/src/controllers/wafpolicy.controller.ts b/app/waf/src/controllers/wafpolicy.controller.ts
@@ -227,9 +227,7 @@ export class WafpolicyController extends BaseController {
         wafpolicy.id,
       );
     } catch (error) {
-      throw new HttpErrors.unprocessableEntity(
-        'check wafpolicy from asg service failed',
-      );
+      throw new HttpErrors.UnprocessableEntity(`ASG error: ${error.message}`);
     }
 
     if (!resp || !resp[0]) {

diff --git a/app/waf/test/acceptance/wafpolicy.controller.acceptance.ts b/app/waf/test/acceptance/wafpolicy.controller.acceptance.ts
@@ -236,6 +236,33 @@ describe('WafpolicyController', () => {
     },
   );
 
+  it(
+    'get ' +
+      prefix +
+      '/wafpolicies/${id}/adcs/${adcId}: ASG fails when check wafpolicy',
+    async () => {
+      const wafpolicy = await givenWafpolicyData(wafapp, {
+        tenantId: 'a random id',
+        public: true,
+      });
+
+      const adc = await givenAdcData(wafapp, {
+        management: {
+          trustedDeviceId: uuid(),
+        },
+      });
+
+      checkWafpolicyStub.throws(new Error('OMG'));
+
+      const resp = await client
+        .get(prefix + `/wafpolicies/${wafpolicy.id}/adcs/${adc.id}`)
+        .set('X-Auth-Token', ExpectedData.userToken)
+        .set('tenant-id', ExpectedData.tenantId)
+        .expect(422);
+
+      expect(resp.body.error.message).equal('ASG error: OMG');
+    },
+  );
   it('get ' + prefix + '/wafpolicies: of all', async () => {
     const wafpolicy = await givenWafpolicyData(wafapp);